Issue 29333291: Noissue - Improve documentation for linkify filter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29333291: Noissue - Improve documentation for linkify filter (Closed)

Created:
Jan. 7, 2016, 3:01 p.m. by kzar

Modified:
Jan. 9, 2016, 10:07 a.m.

Reviewers:
Sebastian Noack

CC:
Thomas Greiner, saroyanm

Visibility:
Public.

Description

Noissue - Improve documentation for linkify filter

Patch Set 1 #

Total comments: 1

Created: Jan. 7, 2016, 3:01 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	README.md	View		1 chunk	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

Jan. 9, 2016, 12:09 a.m. (2016-01-09 00:09:20 UTC) #2

https://codereview.adblockplus.org/29333291/diff/29333292/README.md
File README.md (right):

https://codereview.adblockplus.org/29333291/diff/29333292/README.md#newcode274
README.md:274: most appropriate page language. The language used can also be
specified
"most appreciate language" sounds rather vague. It is the language of the page
the link points to, which is the language of the current page if generated, or
the default language if translations are too incomplete. However, since this
phrasing didn't change, LGTM. Up to you whether you want to address it though.

Expand All Messages | Collapse All Messages