Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333312: Issue 3486 - Issue reporter: don`t access content window to reload the page (Closed)

Created:
Jan. 7, 2016, 7:15 p.m. by Wladimir Palant
Modified:
Jan. 8, 2016, 10:16 p.m.
Reviewers:
Erik
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 3486 - Issue reporter: don`t access content window to reload the page

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M chrome/content/ui/sendReport.js View 14 chunks +24 lines, -22 lines 2 comments Download
M lib/ui.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6
Wladimir Palant
Jan. 7, 2016, 7:15 p.m. (2016-01-07 19:15:30 UTC) #1
Erik
LGTM
Jan. 8, 2016, 3:56 a.m. (2016-01-08 03:56:48 UTC) #2
Erik
https://codereview.adblockplus.org/29333312/diff/29333313/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333312/diff/29333313/chrome/content/ui/sendReport.js#newcode812 chrome/content/ui/sendReport.js:812: this.browser.reload(); the only problem I see with this is ...
Jan. 8, 2016, 4 a.m. (2016-01-08 04:00:46 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29333312/diff/29333313/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333312/diff/29333313/chrome/content/ui/sendReport.js#newcode812 chrome/content/ui/sendReport.js:812: this.browser.reload(); On 2016/01/08 04:00:45, Erik wrote: > the only ...
Jan. 8, 2016, 1:46 p.m. (2016-01-08 13:46:20 UTC) #4
Erik
On 2016/01/08 13:46:20, Wladimir Palant wrote: > https://codereview.adblockplus.org/29333312/diff/29333313/chrome/content/ui/sendReport.js > File chrome/content/ui/sendReport.js (right): > > https://codereview.adblockplus.org/29333312/diff/29333313/chrome/content/ui/sendReport.js#newcode812 ...
Jan. 8, 2016, 10:15 p.m. (2016-01-08 22:15:36 UTC) #5
Erik
Jan. 8, 2016, 10:16 p.m. (2016-01-08 22:16:29 UTC) #6
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld