lib/ui.js - Issue 29333320: Issue 3486 - Issue reporter: remove content window access

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/ui.js

Issue 29333320: Issue 3486 - Issue reporter: remove content window access (Closed)

Patch Set: Created Jan. 7, 2016, 7:32 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/ui.js

===================================================================

--- a/lib/ui.js

+++ b/lib/ui.js

@@ -794,17 +794,17 @@ let UI = exports.UI =

{

let uri = this.getCurrentLocation(window);

if (uri)

{

let {getBrowser} = require("appSupport");

let browser = getBrowser(window);

if ("selectedBrowser" in browser)

browser = browser.selectedBrowser;

- window.openDialog("chrome://adblockplus/content/ui/sendReport.xul", "_blank", "chrome,centerscreen,resizable=no", browser.contentWindow, uri, browser);

+ window.openDialog("chrome://adblockplus/content/ui/sendReport.xul", "_blank", "chrome,centerscreen,resizable=no", browser.outerWindowID, uri, browser);

}

/**

* Opens our contribution page.

openContributePage: function(/**Window*/ window)

« no previous file with comments | « chrome/content/ui/sendReport.js ('k') | no next file » | no next file with comments »