Issue 3498 - Improve file mapping / skipping logic

packagerChrome.py

Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 237cb2167ea5d84824d3602ddf20308a0018d828..79db0e83a301b6ae1a6ff281b5cae6dc8f281da0 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -326,12 +326,17 @@ def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuil
     'metadata': metadata,
   }
 
+  if metadata.has_option('general', 'skippedPackageFiles'):
+    skip = re.split(r'\s+', metadata.get('general', 'skippedPackageFiles'))
+  else:
+    skip = []

[Wladimir Palant, 2016/01/12 12:16:33]

Please don't introduce a new option for that.

  skip = metadata.options('mapping') if metadata.has_section('mapping') else []

Note that the same logic has to be added to the other packagers as well.

[kzar, 2016/01/12 13:09:47]

Ah, much better idea, Done.

+
   files = Files(getPackageFiles(params), getIgnoredFiles(params),
                 process=lambda path, data: processFile(path, data, params))
+  files.read(baseDir, skip=skip)

[Wladimir Palant, 2016/01/12 12:16:33]

Things become inconsistent if you move this up, other packagers read mapped
files first. While I'm not sure why we did it like this, the order should be
changed everywhere or nowhere. I'm leaning towards nowhere, there doesn't seem
to be a good reason for it.

[kzar, 2016/01/12 13:09:47]

Yes I agree and it no longer matters now that we automatically skip mapped files
anyway.

 
   if metadata.has_section('mapping'):
     files.readMappedFiles(metadata.items('mapping'))
-  files.read(baseDir)
 
   if metadata.has_section('convert_js'):
     convertJS(params, files)