Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29333368: Issue 3498 - Improve file mapping / skipping logic (Closed)
Patch Set: Addressed Sebastian's feedback Created Jan. 12, 2016, 5:29 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packager.py ('k') | packagerGecko.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 237cb2167ea5d84824d3602ddf20308a0018d828..f26c953a28d52fceb7a030511f52fbb3623aae50 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -326,12 +326,12 @@ def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuil
'metadata': metadata,
}
+ mapped = metadata.items('mapping') if metadata.has_section('mapping') else []
files = Files(getPackageFiles(params), getIgnoredFiles(params),
process=lambda path, data: processFile(path, data, params))
- if metadata.has_section('mapping'):
- files.readMappedFiles(metadata.items('mapping'))
- files.read(baseDir)
+ files.readMappedFiles(mapped)
+ files.read(baseDir, skip=[opt for opt, _ in mapped])
if metadata.has_section('convert_js'):
convertJS(params, files)
« no previous file with comments | « packager.py ('k') | packagerGecko.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld