Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333400: Issue 3503 - Fixed: Screenshot marker in Issue Reporter is no longer red (Closed)

Created:
Jan. 12, 2016, 4:12 p.m. by Wladimir Palant
Modified:
Jan. 12, 2016, 5:16 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3503 - Fixed: Screenshot marker in Issue Reporter is no longer red

Patch Set 1 #

Patch Set 2 : Better approach, remove asynchronity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M chrome/content/ui/sendReport.js View 1 1 chunk +9 lines, -13 lines 0 comments Download
M lib/child/dataCollector.js View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Jan. 12, 2016, 4:12 p.m. (2016-01-12 16:12:07 UTC) #1
Wladimir Palant
Actually, I realized that converting pixel data to URL wasn't necessary - it can be ...
Jan. 12, 2016, 4:23 p.m. (2016-01-12 16:23:31 UTC) #2
Thomas Greiner
Jan. 12, 2016, 5:05 p.m. (2016-01-12 17:05:52 UTC) #3
LGTM

FYI: This appears to be the relevant section in the standard:
https://www.w3.org/TR/2dcontext2/#concept-canvas-set-bitmap-dimensions

Powered by Google App Engine
This is Rietveld