compiled/ActiveFilter.cpp - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: compiled/ActiveFilter.cpp

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Patch Set: Fixed some bugs and exposed/tested more properties Created Jan. 15, 2016, 3:40 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #include "ActiveFilter.h"

	2

	3 ActiveFilter::ActiveFilter(const std::u16string& text)

	4 : Filter(text), disabled(false), hitCount(0), lastHit(0)

	5 {

	6 }

	7

	8 // API

	9 extern "C"
	Felix Dahlke 2016/01/15 17:00:35 I'm not really a fan of this approach. Have you tr I'm not really a fan of this approach. Have you tried embind [1]? If that works out for us, we won't need to build this C wrapper. If we have to build the C wrapper, I would prefer to move it out of the classes and into a separate file. That's IIRC the common way to do it. [1]: https://kripken.github.io/emscripten-site/docs/porting/connecting_cpp_and_jav...
	10 {

	11 EXPOSE_PROPERTY(ActiveFilter, bool, disabled);

	12 EXPOSE_PROPERTY(ActiveFilter, unsigned int, hitCount);

	13 EXPOSE_PROPERTY(ActiveFilter, unsigned int, lastHit);

	14 }

OLD	NEW