compiled/CommentFilter.cpp - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: compiled/CommentFilter.cpp

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Patch Set: Fixed some bugs and exposed/tested more properties Created Jan. 15, 2016, 3:40 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #include "CommentFilter.h"

	2

	3 CommentFilter::CommentFilter(const std::u16string& text)

	4 : Filter(text)

	5 {

	6 }

	7

	8 Filter::Type CommentFilter::Parse(const std::u16string& text)

	9 {

	10 if (text.length() && text[0] == u'!')

	11 return Type::COMMENT;

	12 else

	13 return Type::UNKNOWN;

	14 }

	15

	16 CommentFilter* CommentFilter::Create(const std::u16string& text)

	17 {

	18 Type type = Parse(text);

	19 if (type == Type::UNKNOWN)
	Felix Dahlke 2016/01/15 17:00:35 IMHO it'd make more sense to check for type != Typ IMHO it'd make more sense to check for type != Type::COMMENT here. Wladimir Palant 2016/01/15 20:36:15 Done. Show quoted text On 2016/01/15 17:00:35, Felix Dahlke wrote: > IMHO it'd make more sense to check for type != Type::COMMENT here. Done.
	20 return nullptr;

	21 else

	22 return new CommentFilter(text);

	23 }

	24

	25 Filter::Type CommentFilter::get_type()

	26 {

	27 return Type::COMMENT;

	28 }

OLD	NEW