Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: compiled/InvalidFilter.cpp
Issue
29333474
:
Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Patch Set: Back to manual approach for API
Created Jan. 18, 2016, 12:41 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Fixed some bugs and exposed/tested more properties
Patch Set 3: Using embind
Patch Set 4: Back to manual approach for API
Patch Set 5: Now passing all filter matching tests (without filter options)
Patch Set 6: Almost complete implementation, missing CSS property filters
Patch Set 7: How with CSS property filters
Patch Set 8: Minor improvements
Patch Set 9: Improved performance
Patch Set 10: Fixed annotation for hash buffers
Patch Set 11: Replaced shared_ptr by boost-like intrusive_ptr
Patch Set 12: Call parameters in JS wrappers generated statically
Patch Set 13: Reworked JS binding generation
Patch Set 14: Addressed comments, made String class slightly more sane, slightly cleaned up bindings.cpp
Patch Set 15: Merged filter parsing and normalization
Patch Set 16: Split up String class into two, cleaned up RegExpFilter methods
Patch Set 17: Minor improvements
Patch Set 18: Optimized hash lookup performance a bit
Patch Set 19: Rebased, addressed comments, changed StringMap::find() return value
Patch Set 20: Replaced old filter classes unit tests completely
Patch Set 21: Addressed Sergei`s comments again and added some asserts
Patch Set 22: Addressed Sergei`s comments again
Patch Set 23: Renamed bindings.h into bindings.ipp
Patch Set 24: Got rid of extra output in bindings.js file
Patch Set 25: Updated unit test framework to the current state of the repository
Patch Set 26: Addressed comments from Patch Set 24
Patch Set 27: Addressed comments from Patch Set 26
Patch Set 28: Properly determine ref_counted offset instead of assuming that it is zero
Patch Set 29: Addressed comments from Patch Set 28
Right:
Patch Set 1: None
Patch Set 2: Fixed some bugs and exposed/tested more properties
Patch Set 3: Using embind
Patch Set 4: Back to manual approach for API
Patch Set 5: Now passing all filter matching tests (without filter options)
Patch Set 6: Almost complete implementation, missing CSS property filters
Patch Set 7: How with CSS property filters
Patch Set 8: Minor improvements
Patch Set 9: Improved performance
Patch Set 10: Fixed annotation for hash buffers
Patch Set 11: Replaced shared_ptr by boost-like intrusive_ptr
Patch Set 12: Call parameters in JS wrappers generated statically
Patch Set 13: Reworked JS binding generation
Patch Set 14: Addressed comments, made String class slightly more sane, slightly cleaned up bindings.cpp
Patch Set 15: Merged filter parsing and normalization
Patch Set 16: Split up String class into two, cleaned up RegExpFilter methods
Patch Set 17: Minor improvements
Patch Set 18: Optimized hash lookup performance a bit
Patch Set 19: Rebased, addressed comments, changed StringMap::find() return value
Patch Set 20: Replaced old filter classes unit tests completely
Patch Set 21: Addressed Sergei`s comments again and added some asserts
Patch Set 22: Addressed Sergei`s comments again
Patch Set 23: Renamed bindings.h into bindings.ipp
Patch Set 24: Got rid of extra output in bindings.js file
Patch Set 25: Updated unit test framework to the current state of the repository
Patch Set 26: Addressed comments from Patch Set 24
Patch Set 27: Addressed comments from Patch Set 26
Patch Set 28: Properly determine ref_counted offset instead of assuming that it is zero
Patch Set 29: Addressed comments from Patch Set 28
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
compile
compiled/ActiveFilter.h
compiled/ActiveFilter.cpp
compiled/CommentFilter.h
compiled/CommentFilter.cpp
compiled/ElemHideBase.h
compiled/ElemHideBase.cpp
compiled/ElemHideException.h
compiled/ElemHideException.cpp
compiled/ElemHideFilter.h
compiled/ElemHideFilter.cpp
compiled/Filter.h
compiled/Filter.cpp
compiled/InvalidFilter.h
compiled/InvalidFilter.cpp
compiled/RegExpFilter.h
compiled/RegExpFilter.cpp
compiled/WhiteListFilter.h
compiled/WhiteListFilter.cpp
compiled/api.h
compiled/api.cpp
compiled/shell.js
lib/filterClassesNew.js
test.js
test/filterClasses.js
View unified diff
|
Download patch
« no previous file with comments
|
« compiled/InvalidFilter.h
('k') |
compiled/RegExpFilter.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
#include "InvalidFilter.h"
2
3
InvalidFilter::InvalidFilter(const std::u16string& text,
4
const std::u16string& reason)
5
: Filter(text), reason(reason)
6
{
7
}
8
9
Filter::Type InvalidFilter::GetType() const
10
{
11
return Type::INVALID;
12
}
OLD
NEW
« no previous file with comments
|
« compiled/InvalidFilter.h
('k') |
compiled/RegExpFilter.h »
('j') |
no next file with comments »
Edit Message
Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Created Jan. 14, 2016, 4:40 p.m. by Wladimir Palant
Modified Dec. 21, 2017, 1:03 p.m.
Reviewers: Felix Dahlke, René Jeschke, sergei, hub
Base URL:
Comments: 308
This is Rietveld
Issue 29333474:
