Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: compiled/CommentFilter.cpp

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Patch Set: Addressed comments, made String class slightly more sane, slightly cleaned up bindings.cpp Created Feb. 2, 2016, 5:48 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « compiled/CommentFilter.h ('k') | compiled/ElemHideBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 #include "CommentFilter.h"
2
3 CommentFilter::CommentFilter(const String& text)
4 : Filter(text)
5 {
6 }
7
8 Filter::Type CommentFilter::Parse(const String& text)
9 {
10 if (text.length() && text[0] == u'!')
11 return Type::COMMENT;
12 else
13 return Type::UNKNOWN;
14 }
15
16 CommentFilter* CommentFilter::Create(const String& text)
17 {
18 Type type = Parse(text);
19 if (type == Type::COMMENT)
20 return new CommentFilter(text);
21 else
22 return nullptr;
23 }
24
25 Filter::Type CommentFilter::GetType() const
26 {
27 return Type::COMMENT;
28 }
OLDNEW
« no previous file with comments | « compiled/CommentFilter.h ('k') | compiled/ElemHideBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld