Issue 4125 - [emscripten] Convert filter classes to C++

compiled/CommentFilter.cpp

 #include "CommentFilter.h"
 
-CommentFilter::CommentFilter(const std::u16string& text)
-    : Filter(text)
+CommentFilter::CommentFilter(const String& text)
+    : Filter(Type::COMMENT, text)
 {
 }
 
-Filter::Type CommentFilter::Parse(const std::u16string& text)
+Filter::Type CommentFilter::Parse(const String& text)
 {
   if (text.length() && text[0] == u'!')
     return Type::COMMENT;
   else
     return Type::UNKNOWN;
 }
 
-CommentFilter* CommentFilter::Create(const std::u16string& text)
+CommentFilter* CommentFilter::Create(const String& text)
 {
   Type type = Parse(text);
-  if (type == Type::UNKNOWN)

[Felix Dahlke, 2016/01/15 17:00:35]

IMHO it'd make more sense to check for type != Type::COMMENT here.

[Wladimir Palant, 2016/01/15 20:36:15]

Done.

+  if (type == Type::COMMENT)
+    return new CommentFilter(text);
+  else
     return nullptr;
-  else
-    return new CommentFilter(text);
 }
-
-Filter::Type CommentFilter::get_type()
-{
-  return Type::COMMENT;
-}