Delta Between Two Patch Sets: compiled/InvalidFilter.cpp
Issue 29333474:
Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Left Patch Set: Using embind
Created Jan. 15, 2016, 8:44 p.m.
Right Patch Set: Addressed comments from Patch Set 28
Created March 21, 2017, 10:04 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« compiled/InvalidFilter.h ('k')
|
compiled/RegExpFilter.h » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 #include <emscripten/bind.h> | |
| 2 | |
| 3 #include "InvalidFilter.h" | 1 #include "InvalidFilter.h" |
| 4 | 2 |
| 5 InvalidFilter::InvalidFilter(const std::wstring& text, | 3 InvalidFilter::InvalidFilter(const String& text, |
| 6 const std::wstring& reason) | 4 const String& reason) |
| 7 : Filter(text), reason(reason) | 5 : Filter(Type::INVALID, text), mReason(reason) |
| 8 { | 6 { |
| 9 } | 7 } |
| 10 | |
| 11 Filter::Type InvalidFilter::GetType() const | |
| 12 { | |
| 13 return Type::INVALID; | |
| 14 } | |
| 15 | |
| 16 EMSCRIPTEN_BINDINGS(invalidfilter) | |
| 17 { | |
| 18 using namespace emscripten; | |
| 19 class_<InvalidFilter,base<Filter>>("InvalidFilter") | |
| 20 .property("reason", &InvalidFilter::GetReason); | |
| 21 } | |
| LEFT | RIGHT |
« compiled/InvalidFilter.h ('k')
|
compiled/RegExpFilter.h » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
