lib/filterClassesNew.js - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: lib/filterClassesNew.js

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Left Patch Set: Using embind Created Jan. 15, 2016, 8:44 p.m.

Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 "use strict";	1 "use strict";

2	2

3 let compiled = require("./compiled");	3 let compiled = require("compiled");

4	4 for (let cls of ["Filter", "InvalidFilter", "CommentFilter", "ActiveFilter",

5 let FilterType = compiled.FilterType;	5 "RegExpFilter", "BlockingFilter", "WhitelistFilter", "ElemHideBase",

6 FilterType.INVALID.toString = () => "invalid";	6 "ElemHideFilter", "ElemHideException", "CSSPropertyFilter"])

7 FilterType.COMMENT.toString = () => "comment";	7 {

8 FilterType.BLOCKING.toString = () => "blocking";	8 exports[cls] = compiled[cls];

9 FilterType.WHITELIST.toString = () => "whitelist";	9 }

10 FilterType.ELEMHIDE.toString = () => "elemhide";

11 FilterType.ELEMHIDEEXCEPTION.toString = () => "elemhideexception";

12 FilterType.CSSPROPERTY.toString = () => "cssproperty";

13

14 exports.Filter = compiled.Filter;

15 exports.InvalidFilter = compiled.InvalidFilter;

16 exports.CommentFilter = compiled.CommentFilter;

17 exports.ActiveFilter = compiled.ActiveFilter;

18 exports.RegExpFilter = compiled.RegExpFilter;

19 exports.WhiteListFilter = compiled.WhiteListFilter;

20 exports.ElemHideBase = compiled.ElemHideBase;

21 exports.ElemHideFilter = compiled.ElemHideFilter;

22 exports.ElemHideException = compiled.ElemHideException;

23 exports.CSSPropertyFilter = compiled.CSSPropertyFilter;

LEFT	RIGHT