compiled/InvalidFilter.cpp - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/InvalidFilter.cpp

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Left Patch Set: Almost complete implementation, missing CSS property filters Created Jan. 20, 2016, 12:04 p.m.

Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #include "InvalidFilter.h"	1 #include "InvalidFilter.h"

2	2

3 InvalidFilter::InvalidFilter(const std::u16string& text,	3 InvalidFilter::InvalidFilter(const String& text,

4 const std::u16string& reason)	4 const String& reason)

5 : Filter(text), reason(reason)	5 : Filter(Type::INVALID, text), mReason(reason)

6 {	6 {

7 }	7 }

8

9 Filter::Type InvalidFilter::GetType() const

10 {

11 return Type::INVALID;

12 }

LEFT	RIGHT