Issue 4125 - [emscripten] Convert filter classes to C++

compiled/RegExpFilter.h

-#ifndef ADBLOCK_PLUS_REG_EXP_FILTER_H
-#define ADBLOCK_PLUS_REG_EXP_FILTER_H
+#pragma once
 
 #include "Filter.h"
 #include "ActiveFilter.h"
 
 enum class TrippleState {YES, NO, ANY};
 
 struct RegExpFilterData
 {
   mutable String::size_type mPatternStart;
   union
@@ skipping 19 matching lines @@
   {
     mRegexpId = regexpId;
     mPatternStart = String::npos;
   }
 
   bool HasRegExp() const
   {
     return RegExpParsingDone() && mRegexpId;
   }
 
-  const String GetRegExpSource(const String& text) const
+  const DependentString GetRegExpSource(const String& text) const
   {
-    return String(text, mPatternStart, mPatternEnd - mPatternStart);
+    return DependentString(text, mPatternStart, mPatternEnd - mPatternStart);
   }
 
   bool DomainsParsingDone() const
   {
     return mDomainsStart == String::npos;
   }
 
   void SetDomainsParsingDone() const
   {
     mDomainsStart = String::npos;
   }
 
-  const String GetDomainsSource(const String& text) const
+  const DependentString GetDomainsSource(const String& text) const
   {
-    return String(text, mDomainsStart, mDomainsEnd - mDomainsStart);
+    return DependentString(text, mDomainsStart, mDomainsEnd - mDomainsStart);
   }
 
   bool SitekeyParsingDone() const
   {
     return mSitekeysStart == String::npos;
   }
 
   void SetSitekeysParsingDone() const
   {
     mSitekeysStart = String::npos;
   }
 
-  const String GetSitekeysSource(const String& text) const
+  const DependentString GetSitekeysSource(const String& text) const
   {
-    return String(text, mSitekeysStart, mSitekeysEnd - mSitekeysStart);
+    return DependentString(text, mSitekeysStart, mSitekeysEnd - mSitekeysStart);
   }
 };
 
-class RegExpFilter : public ActiveFilter, protected RegExpFilterData
+class RegExpFilter : public ActiveFilter
 {
 private:
-  static void ParseOptions(String& text, String& error, RegExpFilterData& data,
-      String::size_type optionsStart);
-  static void ParseOption(String& text, String& error, RegExpFilterData& data,
-      int optionStart, int optionEnd, int valueStart, int valueEnd);
   void ParseSitekeys(const String& sitekeys) const;
 
 protected:
-  virtual DomainMap* GetDomains() const;
-  virtual SitekeySet* GetSitekeys() const;
+  RegExpFilterData mData;
+
+  DomainMap* GetDomains() const override;
+  SitekeySet* GetSitekeys() const override;
 public:
-  RegExpFilter(const String& text, const RegExpFilterData& data);
+  explicit RegExpFilter(Type type, const String& text, const RegExpFilterData& data);
   ~RegExpFilter();
-  static Type Parse(String& text, String& error, RegExpFilterData& data);
+  static Type Parse(DependentString& text, DependentString& error,
+      RegExpFilterData& data);
   EMSCRIPTEN_KEEPALIVE static void InitJSTypes();
-  static String RegExpFromSource(const String& source);
-  Type GetType() const;
+  static OwnedString RegExpFromSource(const String& source);
   EMSCRIPTEN_KEEPALIVE bool Matches(const String& location, int typeMask,
-      String& docDomain, bool thirdParty, const String& sitekey) const;
+      DependentString& docDomain, bool thirdParty, const String& sitekey) const;
 };
-
-#endif