Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/ElemHideBase.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Left Patch Set: Split up String class into two, cleaned up RegExpFilter methods Created Feb. 4, 2016, 7:20 p.m.
Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/CommentFilter.cpp ('k') | compiled/ElemHideBase.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #ifndef ADBLOCK_PLUS_ELEM_HIDE_BASE_H 1 #pragma once
2 #define ADBLOCK_PLUS_ELEM_HIDE_BASE_H
3 2
4 #include <cstddef> 3 #include <cstddef>
5 4
6 #include "ActiveFilter.h" 5 #include "ActiveFilter.h"
7 6
8 struct ElemHideBaseData 7 struct ElemHideBaseData
9 { 8 {
10 String::size_type mDomainsEnd; 9 String::size_type mDomainsEnd;
11 String::size_type mSelectorStart; 10 String::size_type mSelectorStart;
12 11
(...skipping 18 matching lines...) Expand all
31 } 30 }
32 31
33 const DependentString GetSelector(const String& text) const 32 const DependentString GetSelector(const String& text) const
34 { 33 {
35 return DependentString(text, mSelectorStart); 34 return DependentString(text, mSelectorStart);
36 } 35 }
37 }; 36 };
38 37
39 struct ElemHideData; 38 struct ElemHideData;
40 39
41 class ElemHideBase : public ActiveFilter, protected ElemHideBaseData 40 class ElemHideBase : public ActiveFilter
42 { 41 {
42 protected:
43 ElemHideBaseData mData;
43 public: 44 public:
44 ElemHideBase(const String& text, const ElemHideBaseData& data); 45 explicit ElemHideBase(Type type, const String& text, const ElemHideBaseData& d ata);
45 static Type Parse(DependentString& text, ElemHideData& data); 46 static Type Parse(DependentString& text, ElemHideData& data);
46 47
47 EMSCRIPTEN_KEEPALIVE const DependentString GetSelector() const 48 EMSCRIPTEN_KEEPALIVE const DependentString GetSelector() const
48 { 49 {
49 return ElemHideBaseData::GetSelector(mText); 50 return mData.GetSelector(mText);
50 } 51 }
51 52
52 EMSCRIPTEN_KEEPALIVE OwnedString GetSelectorDomain() const; 53 EMSCRIPTEN_KEEPALIVE OwnedString GetSelectorDomain() const;
53 }; 54 };
54
55 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld