Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/ElemHideBase.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Left Patch Set: Minor improvements Created Feb. 6, 2016, 8:29 a.m.
Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/CommentFilter.cpp ('k') | compiled/ElemHideBase.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #pragma once 1 #pragma once
2 2
3 #include <cstddef> 3 #include <cstddef>
4 4
5 #include "ActiveFilter.h" 5 #include "ActiveFilter.h"
6 6
7 struct ElemHideBaseData 7 struct ElemHideBaseData
8 { 8 {
9 String::size_type mDomainsEnd; 9 String::size_type mDomainsEnd;
10 String::size_type mSelectorStart; 10 String::size_type mSelectorStart;
(...skipping 19 matching lines...) Expand all
30 } 30 }
31 31
32 const DependentString GetSelector(const String& text) const 32 const DependentString GetSelector(const String& text) const
33 { 33 {
34 return DependentString(text, mSelectorStart); 34 return DependentString(text, mSelectorStart);
35 } 35 }
36 }; 36 };
37 37
38 struct ElemHideData; 38 struct ElemHideData;
39 39
40 class ElemHideBase : public ActiveFilter, protected ElemHideBaseData 40 class ElemHideBase : public ActiveFilter
41 { 41 {
42 protected:
43 ElemHideBaseData mData;
42 public: 44 public:
43 ElemHideBase(const String& text, const ElemHideBaseData& data); 45 explicit ElemHideBase(Type type, const String& text, const ElemHideBaseData& d ata);
44 static Type Parse(DependentString& text, ElemHideData& data); 46 static Type Parse(DependentString& text, ElemHideData& data);
45 47
46 EMSCRIPTEN_KEEPALIVE const DependentString GetSelector() const 48 EMSCRIPTEN_KEEPALIVE const DependentString GetSelector() const
47 { 49 {
48 return ElemHideBaseData::GetSelector(mText); 50 return mData.GetSelector(mText);
49 } 51 }
50 52
51 EMSCRIPTEN_KEEPALIVE OwnedString GetSelectorDomain() const; 53 EMSCRIPTEN_KEEPALIVE OwnedString GetSelectorDomain() const;
52 }; 54 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld