Issue 4125 - [emscripten] Convert filter classes to C++

compiled/CSSPropertyFilter.h

 #pragma once
 
 #include <cstddef>
 
 #include "Filter.h"
 #include "ElemHideBase.h"
 
 struct CSSPropertyFilterData
 {
   String::size_type mPrefixEnd;
@@ skipping 15 matching lines @@
   const DependentString GetSelectorSuffix(const String& text) const
   {
     return DependentString(text, mSuffixStart);
   }
 };
 
 struct ElemHideData : ElemHideBaseData, CSSPropertyFilterData
 {
 };
 
-class CSSPropertyFilter: public ElemHideBase, protected CSSPropertyFilterData
+class CSSPropertyFilter: public ElemHideBase
 {
+protected:
+  CSSPropertyFilterData mPropertyData;
 public:
-  CSSPropertyFilter(const String& text, const ElemHideData& data);
-  Type GetType() const;

[sergei, 2016/02/17 12:54:32]

Do you mind to add `override` (without `virtual`) everywhere for implementation
of virtual methods?

[Wladimir Palant, 2016/02/18 16:06:39]

Done.

+  explicit CSSPropertyFilter(const String& text, const ElemHideData& data);
   EMSCRIPTEN_KEEPALIVE OwnedString GetRegExpString() const;
   EMSCRIPTEN_KEEPALIVE const DependentString GetSelectorPrefix() const
   {
-    return CSSPropertyFilterData::GetSelectorPrefix(mText, mSelectorStart);
+    return mPropertyData.GetSelectorPrefix(mText, mData.mSelectorStart);
   }
   EMSCRIPTEN_KEEPALIVE const DependentString GetSelectorSuffix() const
   {
-    return CSSPropertyFilterData::GetSelectorSuffix(mText);
+    return mPropertyData.GetSelectorSuffix(mText);
   }
 };