Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/InvalidFilter.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Left Patch Set: Rebased, addressed comments, changed StringMap::find() return value Created Feb. 18, 2016, 4:02 p.m.
Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/Filter.cpp ('k') | compiled/InvalidFilter.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #pragma once 1 #pragma once
2 2
3 #include "Filter.h" 3 #include "Filter.h"
4 4
5 class InvalidFilter : public Filter 5 class InvalidFilter : public Filter
6 { 6 {
7 public: 7 public:
8 InvalidFilter(const String& text, const String& reason); 8 explicit InvalidFilter(const String& text, const String& reason);
9 Type GetType() const override; 9 EMSCRIPTEN_KEEPALIVE const String& GetReason() const
10 EMSCRIPTEN_KEEPALIVE const DependentString GetReason() const
11 { 10 {
12 return mReason; 11 return mReason;
13 }; 12 };
14 private: 13 private:
15 OwnedString mReason; 14 OwnedString mReason;
16 }; 15 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld