compiled/InvalidFilter.h - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/InvalidFilter.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Left Patch Set: Addressed Sergei`s comments again and added some asserts Created Feb. 23, 2016, 12:30 p.m.

Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #pragma once	1 #pragma once

2	2

3 #include "Filter.h"	3 #include "Filter.h"

4	4

5 class InvalidFilter : public Filter	5 class InvalidFilter : public Filter

6 {	6 {

7 public:	7 public:

8 InvalidFilter(const String& text, const String& reason);	8 explicit InvalidFilter(const String& text, const String& reason);

9 Type GetType() const override;	9 EMSCRIPTEN_KEEPALIVE const String& GetReason() const

10 EMSCRIPTEN_KEEPALIVE const DependentString GetReason() const

11 {	10 {

12 return mReason;	11 return mReason;

13 };	12 };

14 private:	13 private:

15 OwnedString mReason;	14 OwnedString mReason;

16 };	15 };

LEFT	RIGHT