Issue 4125 - [emscripten] Convert filter classes to C++

compile

 #!/usr/bin/env python
 
 import json
 import os
 import re
 import subprocess
 import warnings
 
 EMSCRIPTEN_PATH = '../emscripten'
 SOURCE_DIR = './compiled'
@@ skipping 28 matching lines @@
   env = {}
   output = subprocess.check_output([
       '/bin/bash', '-c', os.path.join(EMSCRIPTEN_PATH, 'emsdk_env.sh')])
   for line in output.splitlines():
     match = re.search(r'^\s*PATH\s*\+=\s*(.*)', line)
     if match:
       path.append(match.group(1))
     match = re.search(r'^\s*(\w+)\s*=\s*(.*)', line)
     if match:
       env[match.group(1)] = match.group(2)
-  env['PATH'] = ':'.join([os.environ['PATH']] + path)

[sergei, 2017/01/10 15:57:27]

Should not we use os.pathsep instead of ':' here?

[Wladimir Palant, 2017/03/13 17:41:49]

Done.

+  env['PATH'] = os.pathsep.join([os.environ['PATH']] + path)
   return env
 
 def generate_bindings(env):
   params = [os.path.join(env['EMSCRIPTEN'], 'emcc'), BINDINGS_FILE,
     '-o', BINDINGS_GENERATOR, '-std=gnu++14', '-DPRINT_BINDINGS',
     '-s', 'WARN_ON_UNDEFINED_SYMBOLS=0',
   ]
   subprocess.check_call(params, env=env)
 
   node = subprocess.check_output('which node', env=env, shell=True).strip();
@@ skipping 10 matching lines @@
   params.extend('-D' + flag for flag in DEFINES)
   for key, value in GENERATION_PARAMS.iteritems():
     params.extend(['-s', '%s=%s' % (key, str(value))])
   params.extend(ADDITIONAL_PARAMS)
   subprocess.check_call(params, env=env)
 
 if __name__ == '__main__':
   env = getenv()
   generate_bindings(env)
   run_compiler(env)