compiled/ActiveFilter.h - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/ActiveFilter.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Left Patch Set: Addressed comments from Patch Set 24 Created Dec. 6, 2016, 10:43 a.m.

Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #pragma once	1 #pragma once

2	2

3 #include <emscripten.h>	3 #include <emscripten.h>

4	4

5 #include "Filter.h"	5 #include "Filter.h"

6 #include "StringMap.h"	6 #include "StringMap.h"

7	7

8 #define FILTER_PROPERTY(type, name, getter, setter) \	8 #define FILTER_PROPERTY(type, name, getter, setter) \

9 private:\	9 private:\

10 type name;\	10 type name;\

(...skipping 23 matching lines...) Expand all Loading...
34 typedef StringSet SitekeySet;	34 typedef StringSet SitekeySet;

35 void ParseDomains(const String& domains, String::value_type separator) const;	35 void ParseDomains(const String& domains, String::value_type separator) const;

36 void AddSitekey(const String& sitekey) const;	36 void AddSitekey(const String& sitekey) const;

37 virtual DomainMap* GetDomains() const;	37 virtual DomainMap* GetDomains() const;

38 virtual SitekeySet* GetSitekeys() const;	38 virtual SitekeySet* GetSitekeys() const;

39 mutable std::unique_ptr<DomainMap> mDomains;	39 mutable std::unique_ptr<DomainMap> mDomains;

40 mutable std::unique_ptr<SitekeySet> mSitekeys;	40 mutable std::unique_ptr<SitekeySet> mSitekeys;

41 private:	41 private:

42 bool mIgnoreTrailingDot;	42 bool mIgnoreTrailingDot;

43 public:	43 public:

44 ActiveFilter(Type type, const String& text, bool ignoreTrailingDot);	44 explicit ActiveFilter(Type type, const String& text, bool ignoreTrailingDot);

45 FILTER_PROPERTY(bool, mDisabled, GetDisabled, SetDisabled);	45 FILTER_PROPERTY(bool, mDisabled, GetDisabled, SetDisabled);

46 FILTER_PROPERTY(unsigned int, mHitCount, GetHitCount, SetHitCount);	46 FILTER_PROPERTY(unsigned int, mHitCount, GetHitCount, SetHitCount);

47 FILTER_PROPERTY(unsigned int, mLastHit, GetLastHit, SetLastHit);	47 FILTER_PROPERTY(unsigned int, mLastHit, GetLastHit, SetLastHit);

48 bool EMSCRIPTEN_KEEPALIVE IsActiveOnDomain(DependentString& docDomain,	48 bool EMSCRIPTEN_KEEPALIVE IsActiveOnDomain(DependentString& docDomain,

49 const String& sitekey) const;	49 const String& sitekey) const;

50 bool EMSCRIPTEN_KEEPALIVE IsActiveOnlyOnDomain(DependentString& docDomain) con st;	50 bool EMSCRIPTEN_KEEPALIVE IsActiveOnlyOnDomain(DependentString& docDomain) con st;

51 bool EMSCRIPTEN_KEEPALIVE IsGeneric() const;	51 bool EMSCRIPTEN_KEEPALIVE IsGeneric() const;

52 OwnedString EMSCRIPTEN_KEEPALIVE Serialize() const;	52 OwnedString EMSCRIPTEN_KEEPALIVE Serialize() const;

53 };	53 };

LEFT	RIGHT