Issue 4125 - [emscripten] Convert filter classes to C++

compiled/StringMap.h

 #pragma once
 
 #include <cstddef>
 #include <cmath>
 #include <initializer_list>
 #include <memory>
 
 #include "String.h"
 #include "debug.h"
 
@@ skipping 73 matching lines @@
   template<typename Entry>
   class HashContainer
   {
   public:
     typedef Entry entry_type;
     typedef size_t size_type;
     typedef HashContainerIterator<Entry> const_iterator;
     typedef HashContainerReference<const Entry> const_reference;
 
   private:
-    HashContainer(const HashContainer& other);
+    explicit HashContainer(const HashContainer& other);
     void operator=(const HashContainer& other);
 
   protected:
     static constexpr size_type MIN_BUCKETS = 1;
     static constexpr double LOAD_FACTOR = 0.8;
     std::unique_ptr<entry_type[]> mBuckets;
     size_type mBucketCount;
     size_type mEntryCount;
 
 #if defined(DEBUG)
@@ skipping 25 matching lines @@
     entry_type* find_bucket(const String& key) const
     {
       size_type h = hash(key);
 
       // This does quadratic probing, effectively the following formula is used:
       // pos = (hash + 1/2 i + 1/2 i ^ 2) mod bucketCount
       for (size_type i = 0; ; ++i)
       {
         // mBucketCount is 2^n so (h & mBucketCount - 1) is equivalent to
         // h % mBucketCount but significantly faster.
-        entry_type* entry = &mBuckets[h & mBucketCount - 1];

[sergei, 2017/01/10 15:58:04]

Could we put "h & (mBucketCount - 1)" to hide compiler warning?

[Wladimir Palant, 2017/03/13 17:42:23]

Done.

+        entry_type* entry = &mBuckets[h & (mBucketCount - 1)];
         if (entry->first.is_invalid() || entry->first.equals(key))
           return entry;
         h += i;
       }
     }
 
     void resize(size_type bucketCount)
     {
       std::unique_ptr<entry_type[]> oldBuckets(std::move(mBuckets));
       size_type oldCount = mBucketCount;
@@ skipping 175 matching lines @@
   const_reference find(const String& key) const
   {
     return super::find(key);
   }
 
   reference find(const String& key)
   {
     return reference(this, key, super::find_bucket(key));
   }
 };