Issue 4125 - [emscripten] Convert filter classes to C++

compiled/ActiveFilter.h

Index: compiled/ActiveFilter.h
===================================================================
new file mode 100644
--- /dev/null
+++ b/compiled/ActiveFilter.h
@@ -0,0 +1,18 @@
+#ifndef ADBLOCKPLUS_ACTIVEFILTER_H

[Felix Dahlke, 2016/01/15 17:00:35]

Nit: Words in camel cased names should be separated by an underscore in include
guards, i.e. `ADBLOCK_PLUS_ACTIVE_FILTER`.

[Wladimir Palant, 2016/01/15 20:36:15]

Done.

+#define ADBLOCKPLUS_ACTIVEFILTER_H
+
+#include <string>
+
+#include "tools.h"
+#include "Filter.h"
+
+class ActiveFilter : public Filter
+{
+public:
+  ActiveFilter(const std::u16string& text);

[Felix Dahlke, 2016/01/15 17:00:35]

Please use the explicit keyword for single parameter constructors - unless you
actually want the automatic conversion.

[Felix Dahlke, 2016/01/15 17:00:35]

I'd prefer to go for std::wstring, we also use it in libadblockplus to store JS
strings, and the Emscripten tests all use std::wstring.

[Wladimir Palant, 2016/01/15 20:36:15]

Done.

[Wladimir Palant, 2016/01/15 20:36:15]

Done though merely as a side-effect of using embind. As explained on IRC, using
char16_t is preferable because unlike wchar_t it is a fixed-width type and it's
also saves us some memory. Well, embind doesn't support std::u16string and it
crashes if size of wchar_t isn't 4 bytes.

+  FILTER_PROPERTY(bool, disabled);
+  FILTER_PROPERTY(unsigned int, hitCount);
+  FILTER_PROPERTY(unsigned int, lastHit);
+};
+
+#endif