Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Unified Diff: compiled/pre.js
Issue
29333474
:
Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Patch Set: Fixed some bugs and exposed/tested more properties
Created Jan. 15, 2016, 3:40 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
compile
compiled/ActiveFilter.h
compiled/ActiveFilter.cpp
compiled/CommentFilter.h
compiled/CommentFilter.cpp
compiled/ElemHideBase.h
compiled/ElemHideBase.cpp
compiled/ElemHideException.h
compiled/ElemHideException.cpp
compiled/ElemHideFilter.h
compiled/ElemHideFilter.cpp
compiled/Filter.h
compiled/Filter.cpp
compiled/InvalidFilter.h
compiled/InvalidFilter.cpp
compiled/RegExpFilter.h
compiled/RegExpFilter.cpp
compiled/WhiteListFilter.h
compiled/WhiteListFilter.cpp
compiled/post.js
compiled/pre.js
compiled/tools.h
compiled/tools.cpp
lib/compiledTools.js
lib/filterClassesNew.js
test.js
test/filterClasses.js
View side-by-side diff with in-line comments
Download patch
« compiled/Filter.cpp
('K') |
« compiled/post.js
('k') |
compiled/tools.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: compiled/pre.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/compiled/pre.js
@@ -0,0 +1,4 @@
+function print(str)
+{
+ Cu.reportError(str);
+}
« compiled/Filter.cpp
('K') |
« compiled/post.js
('k') |
compiled/tools.h »
('j') |
no next file with comments »
Edit Message
Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Created Jan. 14, 2016, 4:40 p.m. by Wladimir Palant
Modified Dec. 21, 2017, 1:03 p.m.
Reviewers: Felix Dahlke, René Jeschke, sergei, hub
Base URL:
Comments: 308
This is Rietveld