metadata.common - Issue 29333514: Issue 3515 - Added polyfill for ES6 promises

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 29333514: Issue 3515 - Added polyfill for ES6 promises (Closed)

Left Patch Set: Created Jan. 14, 2016, 5:19 p.m.

Right Patch Set: Addressed comments Created Jan. 19, 2016, 11:33 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.10	2 version = 1.10

3 backgroundScripts =	3 backgroundScripts = lib/polyfills/promise.js

4 lib/polyfill/promise.js
kzar 2016/01/15 19:00:41 Nit: Should call the directory polyfills? Nit: Should call the directory polyfills? Sebastian Noack 2016/01/19 11:34:22 Fine with me. Show quoted text On 2016/01/15 19:00:41, kzar wrote: > Nit: Should call the directory polyfills? Fine with me.
5 ext/common.js	4 ext/common.js

6 ext/background.js	5 ext/background.js

7 lib/compat.js	6 lib/compat.js

8 lib/info.js	7 lib/info.js

9 lib/adblockplus.js	8 lib/adblockplus.js

10 lib/punycode.js	9 lib/punycode.js

11 lib/publicSuffixList.js	10 lib/publicSuffixList.js

12 lib/sha1.js	11 lib/sha1.js

13 lib/jsbn.js	12 lib/jsbn.js

14 lib/rsa.js	13 lib/rsa.js

(...skipping 118 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
133 addSubscription.label	132 addSubscription.label

134 addSubscriptionAdd.label	133 addSubscriptionAdd.label

135 addSubscriptionOther.label	134 addSubscriptionOther.label

136 acceptableAds2.label	135 acceptableAds2.label

137 viewList.label	136 viewList.label

138 readMore.label	137 readMore.label

139 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	138 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

140 title.label	139 title.label

141 adblockplus/chrome/locale/*/meta.properties = =name	140 adblockplus/chrome/locale/*/meta.properties = =name

142 adblockplusui/locale//firstRun.json = =	141 adblockplusui/locale//firstRun.json = =

LEFT	RIGHT