Issue 3515 - Use fetch() API instead XMLHttpRequest (Platform)

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 169 matching lines @@
       checkbox.checked = descriptor.toggle();
 
     Prefs[id] = checkbox.checked;
   }, false);
 }
 
 var delayedSubscriptionSelection = null;
 
 function loadRecommendations()
 {
-  var request = new XMLHttpRequest();
-  request.open("GET", "subscriptions.xml");
-  request.onload = function()
-  {
-    var selectedIndex = 0;
-    var selectedPrefix = null;
-    var matchCount = 0;
+  fetch("subscriptions.xml")
+    .then(function(response)
+    {
+      return response.text();
+    })
+    .then(function(text)
+    {
+      var selectedIndex = 0;
+      var selectedPrefix = null;
+      var matchCount = 0;
 
-    var list = document.getElementById("subscriptionSelector");
-    var elements = request.responseXML.documentElement.getElementsByTagName("subscription");
-    for (var i = 0; i < elements.length; i++)
-    {
-      var element = elements[i];
-      var option = new Option();
-      option.text = element.getAttribute("title") + " (" + element.getAttribute("specialization") + ")";
-      option._data = {
-        title: element.getAttribute("title"),
-        url: element.getAttribute("url"),
-        homepage: element.getAttribute("homepage")
-      };
+      var list = document.getElementById("subscriptionSelector");
+      var doc = new DOMParser().parseFromString(text, "application/xml");
+      var elements = doc.documentElement.getElementsByTagName("subscription");
 
-      var prefix = Utils.checkLocalePrefixMatch(element.getAttribute("prefixes"));
-      if (prefix)
+      for (var i = 0; i < elements.length; i++)
       {
-        option.style.fontWeight = "bold";
-        option.style.backgroundColor = "#E0FFE0";
-        option.style.color = "#000000";
-        if (!selectedPrefix || selectedPrefix.length < prefix.length)
+        var element = elements[i];
+        var option = new Option();
+        option.text = element.getAttribute("title") + " (" + element.getAttribute("specialization") + ")";

[kzar, 2016/01/17 17:14:06]

Nit: Mind fixing the long lines here as well while at it?

[Sebastian Noack, 2016/01/19 14:58:10]

Done.

+        option._data = {
+          title: element.getAttribute("title"),
+          url: element.getAttribute("url"),
+          homepage: element.getAttribute("homepage")
+        };
+
+        var prefix = Utils.checkLocalePrefixMatch(element.getAttribute("prefixes"));
+        if (prefix)
         {
-          selectedIndex = i;
-          selectedPrefix = prefix;
-          matchCount = 1;
-        }
-        else if (selectedPrefix && selectedPrefix.length == prefix.length)
-        {
-          matchCount++;
-
-          // If multiple items have a matching prefix of the same length:
-          // Select one of the items randomly, probability should be the same
-          // for all items. So we replace the previous match here with
-          // probability 1/N (N being the number of matches).
-          if (Math.random() * matchCount < 1)
+          option.style.fontWeight = "bold";
+          option.style.backgroundColor = "#E0FFE0";
+          option.style.color = "#000000";
+          if (!selectedPrefix || selectedPrefix.length < prefix.length)
           {
             selectedIndex = i;
             selectedPrefix = prefix;
+            matchCount = 1;
+          }
+          else if (selectedPrefix && selectedPrefix.length == prefix.length)
+          {
+            matchCount++;
+
+            // If multiple items have a matching prefix of the same length:
+            // Select one of the items randomly, probability should be the same
+            // for all items. So we replace the previous match here with
+            // probability 1/N (N being the number of matches).
+            if (Math.random() * matchCount < 1)
+            {
+              selectedIndex = i;
+              selectedPrefix = prefix;
+            }
           }
         }
+        list.appendChild(option);
       }
+
+      var option = new Option();
+      option.text = i18n.getMessage("filters_addSubscriptionOther_label") + "\u2026";
+      option._data = null;
       list.appendChild(option);
-    }
 
-    var option = new Option();
-    option.text = i18n.getMessage("filters_addSubscriptionOther_label") + "\u2026";
-    option._data = null;
-    list.appendChild(option);
+      list.selectedIndex = selectedIndex;
 
-    list.selectedIndex = selectedIndex;
-
-    if (delayedSubscriptionSelection)
-      startSubscriptionSelection.apply(null, delayedSubscriptionSelection);
-  };
-  request.send(null);
+      if (delayedSubscriptionSelection)
+        startSubscriptionSelection.apply(null, delayedSubscriptionSelection);
+    });
 }
 
 function startSubscriptionSelection(title, url)
 {
   var list = document.getElementById("subscriptionSelector");
   if (list.length == 0)
   {
     delayedSubscriptionSelection = [title, url];
     return;
   }
@@ skipping 420 matching lines @@
       links[i].href = arguments[i + 1];
       links[i].setAttribute("target", "_blank");
     }
     else if (typeof arguments[i + 1] == "function")
     {
       links[i].href = "javascript:void(0);";
       links[i].addEventListener("click", arguments[i + 1], false);
     }
   }
 }