Issue 3515 - Use fetch() API instead XMLHttpRequest (UI)

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 294 matching lines @@
       collections.whitelist.addItems(filter);
     }
     else
       collections.customFilters.addItems(filter);
 
     filtersMap[filter.text] = filter;
   }
 
   function loadRecommendations()
   {
-    var request = new XMLHttpRequest();
-    request.open("GET", "subscriptions.xml", false);
-    request.addEventListener("load", function()
-    {
-      var list = document.getElementById("subscriptionSelector");
-      var docElem = request.responseXML.documentElement;
-      var elements = docElem.getElementsByTagName("subscription");
-      for (var i = 0; i < elements.length; i++)
+    fetch("subscriptions.xml")
+      .then(function(response)
       {
-        var element = elements[i];
-        var subscription = Object.create(null);
-        subscription.title = element.getAttribute("title");
-        subscription.url = element.getAttribute("url");
-        subscription.disabled = null;
-        subscription.downloadStatus = null;
-        subscription.homepage = null;
-        subscription.lastSuccess = null;
-        var recommendation = Object.create(null);
-        recommendation.type = element.getAttribute("type");
-        var prefix = element.getAttribute("prefixes");
-        if (prefix)
+        return response.text();
+      })
+      .then(function(text)
+      {
+        var list = document.getElementById("subscriptionSelector");
+        var doc = new DOMParser().parseFromString(text, "application/xml");
+        var elements = doc.documentElement.getElementsByTagName("subscription");
+        for (var i = 0; i < elements.length; i++)
         {
-          prefix = prefix.replace(/\W/g, "_");
-          subscription.title = ext.i18n.getMessage("options_language_" + prefix);
+          var element = elements[i];
+          var subscription = Object.create(null);
+          subscription.title = element.getAttribute("title");
+          subscription.url = element.getAttribute("url");
+          subscription.disabled = null;
+          subscription.downloadStatus = null;
+          subscription.homepage = null;
+          subscription.lastSuccess = null;
+          var recommendation = Object.create(null);
+          recommendation.type = element.getAttribute("type");
+          var prefix = element.getAttribute("prefixes");
+          if (prefix)
+          {
+            prefix = prefix.replace(/\W/g, "_");
+            subscription.title = ext.i18n.getMessage("options_language_" + prefix);
+          }
+          else
+          {
+            var type = recommendation.type.replace(/\W/g, "_");
+            subscription.title = ext.i18n.getMessage("common_feature_" + type + "_title");
+          }
+
+          recommendationsMap[subscription.url] = recommendation;
+          updateSubscription(subscription);
         }
-        else
-        {
-          var type = recommendation.type.replace(/\W/g, "_");
-          subscription.title = ext.i18n.getMessage("common_feature_" + type + "_title");
-        }
-
-        recommendationsMap[subscription.url] = recommendation;
-        updateSubscription(subscription);
-      }
-    }, false);
-    request.send(null);
+      });
   }
 
   function onClick(e)
   {
     var element = e.target;
     while (true)
     {
       if (!element)
         return;
 
@@ skipping 456 matching lines @@
     filter: ["added", "loaded", "removed"]
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "removed", "title"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();