 Issue 29333819:
  Issue 2375 - Implement "Blocking lists" section in new options page  (Closed)
    
  
    Issue 29333819:
  Issue 2375 - Implement "Blocking lists" section in new options page  (Closed) 
  | Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 { | 1 { | 
| 2 "options_page_title": { | 2 "options_page_title": { | 
| 3 "description": "Options page title", | 3 "description": "Options page title", | 
| 4 "message": "Adblock Plus Options" | 4 "message": "Adblock Plus Options" | 
| 5 }, | 5 }, | 
| 6 "options_page_header_1": { | 6 "options_page_header_1": { | 
| 7 "description": "Page title in navigation sidebar", | 7 "description": "Page title in navigation sidebar", | 
| 8 "message": "Options" | 8 "message": "Options" | 
| 9 }, | 9 }, | 
| 10 "options_page_header_2": { | 10 "options_page_header_2": { | 
| (...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 152 "message": "Overview" | 152 "message": "Overview" | 
| 153 }, | 153 }, | 
| 154 "options_tab_ownList": { | 154 "options_tab_ownList": { | 
| 155 "description": "Tab name in Advanced tab", | 155 "description": "Tab name in Advanced tab", | 
| 156 "message": "Edit or create own blocking list" | 156 "message": "Edit or create own blocking list" | 
| 157 }, | 157 }, | 
| 158 "options_tableCol_name": { | 158 "options_tableCol_name": { | 
| 159 "description": "Name of column of subscription list table in Advanced tab", | 159 "description": "Name of column of subscription list table in Advanced tab", | 
| 160 "message": "Name" | 160 "message": "Name" | 
| 161 }, | 161 }, | 
| 162 "options_tableCol_description": { | 162 "options_tableCol_description": { | 
| 
Thomas Greiner
2016/01/19 11:27:27
There's no "description" column anymore so please
 
saroyanm
2016/01/22 09:55:04
Done.
 | |
| 163 "description": "Name of column of subscription list table in Advanced tab", | 163 "description": "Name of column of subscription list table in Advanced tab", | 
| 164 "message": "Description" | 164 "message": "Description" | 
| 165 }, | 165 }, | 
| 166 "options_tableCol_date": { | 166 "options_tableCol_date": { | 
| 167 "description": "Name of column of subscription list table in Advanced tab", | 167 "description": "Name of column of subscription list table in Advanced tab", | 
| 168 "message": "Date" | 168 "message": "Date" | 
| 
Thomas Greiner
2016/01/19 11:27:26
According to the style guide this should be "Last
 
saroyanm
2016/01/22 09:55:05
Done.
 | |
| 169 }, | 169 }, | 
| 170 "options_blockingList_add": { | 170 "options_blockingList_add": { | 
| 171 "description": "Import button in Advanced tab", | 171 "description": "Import button in Advanced tab", | 
| 172 "message": "add/import other blocking list" | 172 "message": "add/import other blocking list" | 
| 173 }, | 173 }, | 
| 174 "options_blockingList_update": { | 174 "options_blockingList_update": { | 
| 175 "description": "Update button in Advanced tab", | 175 "description": "Update button in Advanced tab", | 
| 176 "message": "Update all blocking lists" | 176 "message": "Update all blocking lists" | 
| 
Thomas Greiner
2016/01/19 11:27:27
According to the style guide this should be lower-
 
saroyanm
2016/01/22 09:55:05
Done.
 | |
| 177 }, | 177 }, | 
| 178 "options_customFilters_empty": { | 178 "options_customFilters_empty": { | 
| 179 "description": "Text shown when list of custom filters is empty", | 179 "description": "Text shown when list of custom filters is empty", | 
| 180 "message": "There are no custom filters." | 180 "message": "There are no custom filters." | 
| 181 }, | 181 }, | 
| 182 "options_subscription_lastDownload_invalidURL": { | |
| 183 "description": "Error message in advanced tab", | |
| 184 "message": "Failed, not a valid address" | |
| 185 }, | |
| 186 "options_subscription_lastDownload_connectionError": { | |
| 187 "description": "Error message in advanced tab", | |
| 188 "message": "Failed, download failure" | |
| 189 }, | |
| 190 "options_subscription_lastDownload_invalidData": { | |
| 191 "description": "Error message in advanced tab", | |
| 192 "message": "Failed, not a valid filters list" | |
| 
Thomas Greiner
2016/01/19 11:27:26
Typo: Replace "filters list" with "filter list".
 
saroyanm
2016/01/22 09:55:05
Done.
 | |
| 193 }, | |
| 194 "options_subscription_lastDownload_checksumMismatch": { | |
| 195 "description": "Error message in advanced tab", | |
| 196 "message": "Failed, checksum mismatch" | |
| 197 }, | |
| 198 "options_blockingList_update_now": { | |
| 
Thomas Greiner
2016/01/19 11:27:26
Detail: The naming is a bit inconsistent because s
 
saroyanm
2016/01/22 09:55:03
Done.
 | |
| 199 "description": "Context menu item in advanced tab, appears after click on su bscription", | |
| 200 "message": "update now" | |
| 201 }, | |
| 202 "options_blockingList_website": { | |
| 203 "description": "Context menu item in advanced tab, appears after click on su bscription", | |
| 204 "message": "website" | |
| 205 }, | |
| 206 "options_blockingList_source": { | |
| 207 "description": "Context menu item in advanced tab, appears after click on su bscription", | |
| 208 "message": "source" | |
| 209 }, | |
| 210 "options_blockingList_delete": { | |
| 211 "description": "Context menu item in advanced tab, appears after click on su bscription", | |
| 212 "message": "delete" | |
| 213 }, | |
| 214 "options_blockingList_own_list": { | |
| 215 "description": "Last subscription name in blocking list section in advnaced tab", | |
| 
Thomas Greiner
2016/01/19 11:27:26
Detail: Please don't mention details that depend o
 
Thomas Greiner
2016/01/19 11:27:27
Typo: Replace "advnaced" with "advanced".
 
saroyanm
2016/01/22 09:55:04
Done.
 
saroyanm
2016/01/22 09:55:04
Done.
 | |
| 216 "message": "Own blocking list" | |
| 217 }, | |
| 218 "options_blockingList_edit_own_list": { | |
| 219 "description": "Link next to last subscription name in blocking list section in advnaced tab", | |
| 220 "message": "edit your blocking list" | |
| 
Thomas Greiner
2016/01/19 11:27:27
I thought we decided on calling them "filter lists
 
saroyanm
2016/01/22 09:55:04
Done.
 | |
| 221 }, | |
| 182 "options_customFilters_title": { | 222 "options_customFilters_title": { | 
| 183 "description": "Custom filters option name in Advanced tab", | 223 "description": "Custom filters option name in Advanced tab", | 
| 184 "message": "Blocking rules" | 224 "message": "Blocking rules" | 
| 185 }, | 225 }, | 
| 186 "options_customFilters_textbox_placeholder": { | 226 "options_customFilters_textbox_placeholder": { | 
| 187 "description": "Adding custom filter textbox placeholder text in Advanced ta b", | 227 "description": "Adding custom filter textbox placeholder text in Advanced ta b", | 
| 188 "message": "add your blocking rule here" | 228 "message": "add your blocking rule here" | 
| 189 }, | 229 }, | 
| 190 "options_customFilter_edit": { | 230 "options_customFilter_edit": { | 
| 191 "description": "Label for editing custom filter in Advanced tab", | 231 "description": "Label for editing custom filter in Advanced tab", | 
| (...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 337 }, | 377 }, | 
| 338 "options_language_ro": { | 378 "options_language_ro": { | 
| 339 "description": "Language name shown in add language modal dialog", | 379 "description": "Language name shown in add language modal dialog", | 
| 340 "message": "Romanian" | 380 "message": "Romanian" | 
| 341 }, | 381 }, | 
| 342 "options_language_ru_uk": { | 382 "options_language_ru_uk": { | 
| 343 "description": "Language name shown in add language modal dialog", | 383 "description": "Language name shown in add language modal dialog", | 
| 344 "message": "Russian and Ukrainian" | 384 "message": "Russian and Ukrainian" | 
| 345 } | 385 } | 
| 346 } | 386 } | 
| OLD | NEW |