Issue 2375 - Implement "Blocking lists" section in new options page

i18n.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2015 Eyeo GmbH
+ * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 63 matching lines @@
 
       var className = node.className;
       if (className instanceof SVGAnimatedString)
         className = className.animVal;
       var stringName = className.split(/\s/)[0].substring(5);
 
       ext.i18n.setElementText(node, stringName, arguments);
     }
   }
   addI18nStringsToElements(document);
-  // Content of Template is not rendered on tuntime so we need to add

[Thomas Greiner, 2016/01/27 17:16:59]

Typo: Replace "tuntime" with "runtime".

[saroyanm, 2016/01/28 17:00:13]

Done.

+  // Content of Template is not rendered on runtime so we need to add
   // translation strings for each Template documentFragment content individually 
   var templates = document.querySelectorAll("template");
   for (var i = 0; i < templates.length; i++)
     addI18nStringsToElements(templates[i].content);
 }
 
 // Provides a more readable string of the current date and time
 function i18n_timeDateStrings(when)
 {
   var d = new Date(when);
   var timeString = d.toLocaleTimeString();
 
   var now = new Date();
   if (d.toDateString() == now.toDateString())
     return [timeString];
   else
     return [timeString, d.toLocaleDateString()];
 }
 
-// Formats date string to ["yyyy-mm-dd", "mm:ss"] format
+// Formats date string to ["YYYY-MM-DD", "mm:ss"] format
 function i18n_formatDateTime(when)
 {
   var date = new Date(when);
-  var dateParts = [date.getFullYear(), date.getMonth()+1, date.getDate(),

[Thomas Greiner, 2016/01/27 17:16:58]

Detail: Missing whitespace around `+` operator.

[saroyanm, 2016/01/28 17:00:12]

Done.

+  var dateParts = [date.getFullYear(), date.getMonth() + 1, date.getDate(),
                   date.getHours(), date.getMinutes()];
-  
-  for (var i = 0; i < dateParts.length; i++)
-    if (dateParts[i] < 10)
-      dateParts[i] = "0" + dateParts[i];

[Thomas Greiner, 2016/01/27 17:16:59]

Detail: This is basically what `Array.prototype.map` was meant for so what about
using it instead to make this part a bit cleaner?

[saroyanm, 2016/01/28 17:00:13]

God bless development without IE8!
Done.

 
-  return [dateParts.splice(0, 3).join("-"), dateParts.splice(0, 2).join(":")];

[Thomas Greiner, 2016/01/27 17:16:58]

The first `splice()` removes elements from `dateParts` so the second `splice()`
is not necessary.

Therefore you could either remove the second `splice()` or replace `splice()`
with `slice()`.

[saroyanm, 2016/01/28 17:00:13]

Done.

+  var dateParts = dateParts.map(function(datePart)
+  {
+    return datePart < 10 ? "0" + datePart : datePart;
+  });
+
+  return [dateParts.splice(0, 3).join("-"), dateParts.join(":")];
 }
 
 // Fill in the strings as soon as possible
 window.addEventListener("DOMContentLoaded", loadI18nStrings, true);