Issue 2375 - Implement "Blocking lists" section in new options page

skin/options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 370 matching lines @@
 }
 
 .table.cols
 {
   border-bottom: 1px solid #CDCDCD;
   border-top: 1px solid #CDCDCD;
 }
 
 button[disabled="true"]
 {
+  border-radius: 2px;
   background-color: #ccc;
-  border-radius: 2px;
 }
 
 .table button.delete
 {
   background-color: transparent;
   background-position: -9px -32px;
   border: 0px;
   height: 10px;
   margin-top: 5px;
   -moz-margin-end: 20px;
@@ skipping 15 matching lines @@
 {
   display: flex;
   margin-bottom: 0px;
   padding: 0px;
 }
 
 .tabs.horizontal li
 {
   display: inline-block;
   border-bottom: 1px solid #A1A1A1;
+  padding: 10px 46px;
   color: #3A7BA6;
-  padding: 10px 46px;
   text-align: center;
 }
 
 .icon,
 button[role="checkbox"],
 .table button.delete,
 #content-help a::before,
 #dialog-close::before,
 #custom-filters-add button::after,
 #dialog-body button::before,
@@ skipping 170 matching lines @@
 {
   display: none;
 }
 
 body[data-tab="advanced-allFilterLists"] #all-filter-lists,
 body[data-tab="advanced-customFilters"] #custom-filters
 {
   display: block;
 }
 
 body[data-tab="advanced-allFilterLists"] #content-advanced [data-tab="advanced-allFilterLists"],

[Thomas Greiner, 2016/02/01 18:52:37]

Detail: Mentioning `#content-advanced` is redundant since the tab name already
mentions that it's part of the Advanced tab.

[saroyanm, 2016/02/03 14:04:29]

Done.

[Thomas Greiner, 2016/02/03 14:50:13]

I noticed that this change introduces a regression: Try clicking on the tabs in
the sidebar and you'll notice that the "Advanced" tab's proportions change.

So it seems like we need to revert that change, unfortunately.

[saroyanm, 2016/02/03 17:43:11]

Ach right, because we also specify same data-tab both on sidebar tabs and the
one in advanced, thanks for noticing that.

 body[data-tab="advanced-customFilters"] #content-advanced [data-tab="advanced-customFilters"]
 {
   border-bottom: 2px solid #1E8728;
   padding-bottom: 10px;
   color: black;
   font-weight: 600;
 }
 
 #all-filter-lists .table
 {
   display: inline-block;
 }
 
 #all-filter-lists .table li
 {
   padding-left: 16px;
   padding-right: 16px;
 }
 
-#all-filter-lists .table li > span:first-of-type
-{
-  display: inline-block;
+#all-filter-lists .table li > div
+{
+  display: flex;
   width: 330px;
 }
 
 .table-header
 {
   display: flex;
 }
     
 #filter-lists h3
 {
@@ skipping 26 matching lines @@
   border-top: none;
 }
 
 #all-filter-lists .controls button
 {
   margin-top: 14px;
 }
 
 #all-filter-lists .arrow
 {
+  position: relative;
+  margin: auto 6px;
   border-style: none;
-  position: relative;

[Thomas Greiner, 2016/02/01 18:52:37]

Detail: According to the coding style positioning should come before box
model-related properties.

[saroyanm, 2016/02/03 14:04:30]

Done.

   padding: 0px;
   width: 6px;
   height: 4px;
-  margin: 0px 4px;

[Thomas Greiner, 2016/02/01 18:52:37]

The reason why it looks odd to you to specify `6px` is because there's
whitespace between the subscription title and the arrow. Therefore using `4px`
instead is merely a workaround for the underlying issue.

It seems that specifying `display: flex` on the parent and `vertical-align:
middle; margin: auto 6px;` resolves the issue and properly align it vertically.

[saroyanm, 2016/02/03 14:04:28]

Done, also changed the parent to be block level element, not to have nested
block level element in the inline one.

-  background-color: transparent;

[Thomas Greiner, 2016/02/01 18:52:38]

Detail: Why is that necessary?

[saroyanm, 2016/02/03 14:04:28]

Redundant, do not remember why I have it here. Done. Thanks for noticing.

   background-position: -1px -54px;
   cursor: pointer;
 }
 
 #all-filter-lists .table li:last-of-type a
 {
   color: #3A7BA6;
   text-decoration: none;
   cursor: pointer;
 }
 
-#all-filter-lists .table li:last-of-type span:last-child
+#all-filter-lists .table li:last-of-type > span:last-child
 {
   -webkit-margin-start: auto;
   -moz-margin-start: auto;
+}
+
+#all-filter-lists li.show-message .date,
+#all-filter-lists li.show-message .time,
+#all-filter-lists li:not(.show-message) .message
+{
+  display: none;
 }
 
 .date::before
 {
   content: "";
   -webkit-margin-end: 6px;
   -moz-margin-end: 6px;
   height: 12px;
   width: 12px;
   background-position: -7px -49px;
@@ skipping 237 matching lines @@
   width: 14px;
   left: 30px;
 }
 
 div.context-menu
 {
   position: absolute;
   top: 16px;
   z-index: 1;
   visibility: hidden;
-  border-radius: 3px;

[Thomas Greiner, 2016/02/01 18:52:37]

Detail: Why did you move the border radius to here?

[saroyanm, 2016/02/03 14:04:28]

I think I didn't noticed that. moved to content.

 }
 
 div.context-menu::before
 {
   left: -4px;
 }
 
 html[dir="rtl"] div.context-menu::before
 {
   left: inherit;
   right: -4px;
 }
 
 div.context-menu .content

[Thomas Greiner, 2016/02/01 18:52:38]

Detail: Please add `cursor: default` to avoid showing the pointing cursor when
hovering over non-clickable elements in the context menu.

[saroyanm, 2016/02/03 14:04:27]

Done.

 {
   position: relative;
   left: calc(-50% + 2px);
+  border-radius: 3px;
+  padding: 4px 10px;
   background-color: rgba(45, 45, 45, 0.95);
-  padding: 4px 10px;
+  cursor: default;
 }
 
 html[dir="rtl"] div.context-menu .content
 {
   left: inherit;
   right: -50%;
 }
 
 li.show-context-menu div.context-menu
 {
   visibility: visible;
 }
 
 div.context-menu > div a::before
 {
   content: "";
   -moz-margin-end: 8px;
   -webkit-margin-end: 8px;
 }
 
 div.context-menu > div a
 {
   display: block;
-  text-decoration: none;

[Thomas Greiner, 2016/02/01 18:52:36]

Detail: This property is in the wrong spot according to our coding style since
it belongs into the "Colors and Typography" category.

[saroyanm, 2016/02/03 14:04:29]

Done.

   padding: 7px 4px;
   border-bottom: 1px solid #CDCDCD;
+  text-decoration: none;
   cursor: pointer;
   vertical-align: middle;
 }
 
-div.context-menu > div a:before

[Thomas Greiner, 2016/02/01 18:52:38]

Detail: Replace ":before" with "::before" to make it consistent with the rest of
the code.

[saroyanm, 2016/02/03 14:04:29]

Done.

+div.context-menu > div a::before
 {
   vertical-align: middle;
   height: 16px;
   width: 16px;
 }
 
 div.context-menu > div a:last-child
 {
   border: none;
 }
 
-.context-menu .update-now::before
+.context-menu .update-subscription::before
 {
   background-position: -38px -31px;
 }
 
 .context-menu .website::before
 {
   background-position: -33px -47px;
 }
 
 .context-menu .source::before
@@ skipping 264 matching lines @@
 #other-language .button-add::before
 {
   display: none;
 }
 
 #other-language .display
 {
   -webkit-margin-start: 10px;
   -moz-margin-start: 10px;
 }