Issue 2375 - Implement "Blocking lists" section in new options page

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 155 matching lines @@
         element.setAttribute("data-search", title.toLowerCase());
       var control = element.querySelector(".control[role='checkbox']");
       if (control)
         control.setAttribute("aria-checked", item.disabled == false);
 
       var downloadStatus = item.downloadStatus;
       var dateElement = element.querySelector(".date");
       var timeElement = element.querySelector(".time");
       if(dateElement && timeElement)
       {
-        var error = element.querySelector(".error");
-        if (downloadStatus && downloadStatus != "synchronize_ok")
-        {
-          if (downloadStatus in filterErrors)
-            error.textContent = getMessage(filterErrors[downloadStatus]);
-          else
-            error.textContent = item.downloadStatus;
-          element.classList.add("error");
-        }
-        else if (item.lastDownload > 0)
-        {
-          var dateTime = i18n_formatDateTime(item.lastDownload * 1000);
-          dateElement.textContent = dateTime[0];
-          timeElement.textContent = dateTime[1];
-          element.classList.remove("error", "progress");
-        }
-        else
-        {
-          var text = getMessage("options_filterList_lastDownload_inProgress");

[Thomas Greiner, 2016/02/04 15:28:17]

Interesting that you would set the text only when "lastDownload" is `0` since
that is only the case for subscriptions that haven't been downloaded before.
Please check how it is implemented in the current options page because this
approach seems to require us to work around it by setting "lastDownload" to `0`
explicitly which never occurs in the extension.

[saroyanm, 2016/02/04 17:50:06]

You are right, I've updated the implementation, 
Also tested on production env. looks fine, the only problem is that the
background mock implementation doesn't look too nice, but I assume it's fine
while it's just a mock ?

[Thomas Greiner, 2016/02/04 20:23:44]

Agreed, let's leave it for now if it's merely a minor cosmetic flaw.

-          element.querySelector(".progress").textContent = text;
-          element.classList.add("progress");
-        }
+        var message = element.querySelector(".message");
+        ext.backgroundPage.sendMessage(
+        {
+          type: "subscriptions.isDownloading",
+          url: item.url
+        },
+        function(isDownloading)
+        {
+          if (isDownloading)
+          {
+            var text = getMessage("options_filterList_lastDownload_inProgress");
+            message.textContent = text;
+            element.classList.add("show-message");
+          }
+          else if (downloadStatus && downloadStatus != "synchronize_ok")
+          {
+            if (downloadStatus in filterErrors)
+              message.textContent = getMessage(filterErrors[downloadStatus]);
+            else
+              message.textContent = item.downloadStatus;
+            element.classList.add("show-message");
+          }
+          else if (item.lastDownload > 0)
+          {
+            var dateTime = i18n_formatDateTime(item.lastDownload * 1000);
+            dateElement.textContent = dateTime[0];
+            timeElement.textContent = dateTime[1];
+            element.classList.remove("show-message");
+          }
+        });
       }
       var websiteElement = element.querySelector(".context-menu .website");
       var sourceElement = element.querySelector(".context-menu .source");
       if (websiteElement && item.homepage)
         websiteElement.setAttribute("href", item.homepage);
       if (sourceElement)
         sourceElement.setAttribute("href", item.url);
     }
   };
 
@@ skipping 802 matching lines @@
     filter: ["added", "loaded", "removed"]
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed", "title"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();