Unified Diff: options.html
Issue 29333819:
Issue 2375 - Implement "Blocking lists" section in new options page (Closed)
Patch Set:
Created Jan. 18, 2016, 9:50 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« messageResponder.js ('K')
|
« messageResponder.js ('k')
|
options.js » ('j')
|
options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.html |
| =================================================================== |
| --- a/options.html |
| +++ b/options.html |
| @@ -29,7 +29,7 @@ |
| <script src="i18n.js"></script> |
| <script src="options.js"></script> |
| </head> |
| - <body data-tab="general"> |
| + <body data-tab="advanced,filter-lists"> |
|
Thomas Greiner
2016/01/19 11:27:28
I suppose you added this for testing. Please rever
saroyanm
2016/01/22 09:55:07
Done.
|
| <!-- Navigation sidebar --> |
| <div id="nav-sidebar"> |
| <div id="fixed-sidebar" class="fixed"> |
| @@ -43,7 +43,7 @@ |
| <a class="i18n_options_tab_general"></a> |
| <span class="icon"></span> |
| </li> |
| - <li id="tab-advanced" data-action="switch-tab" data-tab="advanced"> |
| + <li id="tab-advanced" data-action="switch-tab" data-tab="advanced,filter-lists"> |
|
Thomas Greiner
2016/01/19 11:27:28
Detail: "abc,def" looks like a list of elements bu
saroyanm
2016/01/22 09:55:07
No, I would like to indicate that the list of tabs
Thomas Greiner
2016/01/25 15:40:27
I see what you mean but in this case they are depe
saroyanm
2016/01/26 18:36:14
Done.
|
| <a class="i18n_options_tab_advanced"></a> |
| <span class="icon"></span> |
| </li> |
| @@ -213,32 +213,67 @@ |
| <!-- Advanced tab content --> |
| <div id="content-advanced"> |
| <div> |
| - <h1><span class="i18n_options_tweaks_title"></span><a class="i18n_options_readMore tooltip" href="#"></a></h1> |
| - <ul class="table" style="width: auto;"> |
| + <h1> |
| + <span class="i18n_options_tweaks_title"></span> |
| + <a class="i18n_options_readMore tooltip" href="#"></a> |
| + </h1> |
| + <ul class="table"> |
| <li> |
| - <input type="checkbox" id="easylist"/><span id="block-element-explanation" class="i18n_options_tweaks_blockElement"></span></li> |
| + <input type="checkbox" id="easylist"/> |
| + <span id="block-element-explanation" class="i18n_options_tweaks_blockElement"></span> |
| + </li> |
| </ul> |
| </div> |
| <div> |
| - <h1><span class="i18n_options_blockingList_title"></span><a class="i18n_options_readMore tooltip" href="#" target="_blank"></a></h1> |
| - <ul id="blocking-list-tabs" class="tabs horizontal"> |
| - <li class="i18n_options_tab_overview active" data-show="blocking-list-overview"></li><li class="i18n_options_tab_ownList" data-show="custom-filters"></li> |
| + <h1> |
| + <span class="i18n_options_blockingList_title"></span> |
| + <a class="i18n_options_readMore tooltip" href="#"></a> |
| + </h1> |
| + <ul class="tabs horizontal"> |
| + <li class="i18n_options_tab_overview active" data-action="switch-tab" data-tab="advanced,filter-lists"></li> |
| + <li class="i18n_options_tab_ownList" data-action="switch-tab" data-tab="advanced,custom-filters"></li> |
| </ul> |
| - <div id="blocking-list"> |
| - <div id="blocking-list-overview"> |
| - <ul class="table cols" style="width: auto;"> |
| - <li class="col-name"><span class="i18n_options_tableCol_name"></span><span class="i18n_options_tableCol_description"></span><span class="i18n_options_tableCol_date"></span></li> |
| - <li><input type="checkbox" id="easylist"/><span>Easylist</span><span>Adblocking english sites</span><span>15 March 14 - 10:31</span></li> |
| - <li><input type="checkbox" id="easylist+de"/><span>Easylist Germany + Easylist</span><span>Adblocking english + german sites</span><span>15 March 14 - 10:31</span></li> |
| - <li><input type="checkbox" id="annoyance-fb"/><span>Facebook annoyance blocker</span><span>Blocks Facebook annoyances</span><span>15 March 14 - 10:31</span></li> |
| - <li><input type="checkbox" id="annoyance-youtube"/><span>Facebook annoyance blocker</span><span>Blocks Facebook annoyances</span><span>15 March 14 - 10:31</span></li> |
| - <li><input type="checkbox" id="own-list"/><span>Own blocking list</span><span>Your own blocking list</span><span><a href="#">edit your blocking list</a></span></li> |
| + <div id="blocking-lists"> |
| + <div id="filter-lists"> |
| + <ul class="table cols" id="blocking-lists-table"> |
| + <li class="head static"> |
|
Thomas Greiner
2016/01/19 11:27:28
The headline should semantically not be part of th
saroyanm
2016/01/22 09:55:07
Done, it's a bit sad, I couldn't find a way how it
|
| + <span class="i18n_options_tableCol_name"></span> |
| + <span class="i18n_options_tableCol_date"></span> |
| + </li> |
| + <template> |
| + <input type="checkbox" class="control" /> |
| + <span> |
| + <span data-action="open-context-menu" class="display"></span> |
| + <div class="context-menu"> |
| + <a href="#" data-action="open-context-menu" class="arrow"></a> |
|
Thomas Greiner
2016/01/19 11:27:28
I noticed a bunch of positioning styles in "option
saroyanm
2016/01/22 09:55:07
The problem with double div is that I don't have a
Thomas Greiner
2016/01/27 17:16:56
I tried it myself and didn't notice any issues. Wh
saroyanm
2016/01/28 17:00:10
Shouldn't the context menu be relative to anchor e
Thomas Greiner
2016/01/29 17:48:07
According to https://issues.adblockplus.org/attach
saroyanm
2016/01/29 18:56:16
I think I missread the part where you suggested to
|
| + <div role="context-menu"> |
|
Thomas Greiner
2016/01/19 11:27:28
This role value doesn't exist. For now, it should
saroyanm
2016/01/22 09:55:06
I see, done.
|
| + <div class="content"> |
| + <a class="update-now" data-action="update-now" href="#"></a> |
|
Thomas Greiner
2016/01/19 11:27:28
Detail: Please remove hyperlinking to "#" for link
saroyanm
2016/01/22 09:55:06
Done.
|
| + <a class="website" data-action="website" href="#"></a> |
| + <a class="source" data-action="source" href="#"></a> |
| + <a class="delete" data-action="delete" href="#"></a> |
| + </div> |
| + </div> |
| + </div> |
| + </span> |
| + <span class="date"></span> |
| + <span class="time"></span> |
| + </template> |
|
Thomas Greiner
2016/01/19 11:27:28
This causes the selector `.table.cols li:nth-child
saroyanm
2016/01/22 09:55:07
Done.
|
| + <li class="static"> |
| + <input type="checkbox" id="own-list" checked="true" disabled="true" /> |
|
Thomas Greiner
2016/01/19 11:27:28
This checkbox doesn't do anything so either implem
saroyanm
2016/01/22 09:55:08
Not sure if it looks good, if you think it's ugly
Thomas Greiner
2016/01/25 15:40:27
I don't mind to do it in a separate review but we
saroyanm
2016/01/26 18:36:15
Acknowledged.
|
| + <span> |
| + <span class="i18n_options_blockingList_own_list"></span> |
| + </span> |
| + <span data-action="switch-tab,edit-custom-filters" data-tab="advanced,custom-filters"> |
| + <a class="i18n_options_blockingList_edit_own_list" href="#"></a> |
| + </span> |
| + </li> |
| </ul> |
| <div class="controls"> |
| - <button> |
| + <button data-action="open-dialog" data-dialog="custom"> |
| <span class="icon icon-add"></span><span class="i18n_options_blockingList_add"></span> |
| </button> |
| - <button> |
| + <button data-action="update-all-subscriptions"> |
| <span class="icon icon-update"></span><span class="i18n_options_blockingList_update"></span> |
| </button> |
| </div> |
| @@ -350,7 +385,7 @@ |
| </div> |
| <div class="dialog-content-block"> |
| <h3 class="i18n_options_dialog_edit_own_list"></h3> |
| - <button class="i18n_options_dialog_create_own_list" data-action="close-dialog,switch-tab,edit-custom-filters" data-tab="advanced"></button> |
| + <button class="i18n_options_dialog_create_own_list" data-action="close-dialog,switch-tab,edit-custom-filters" data-tab="advanced,custom-filters"></button> |
| </div> |
| </div> |
| <!-- Add predefined subscription --> |
