Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: options.html

Issue 29334038: Issue 2802/2358 - Dynamically generate tooltips in options page (Closed)
Patch Set: Rebased to 536c9b810423 Created March 21, 2016, 2:04 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « locale/en-US/options.json ('k') | options.js » ('j') | options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2016 Eyeo GmbH 4 - Copyright (C) 2006-2016 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 <div id="dialog-background"></div> 76 <div id="dialog-background"></div>
77 77
78 <!-- General tab content --> 78 <!-- General tab content -->
79 <div id="content-general" class="tab-content"> 79 <div id="content-general" class="tab-content">
80 <div> 80 <div>
81 <h1 class="i18n_options_blocking_title"></h1> 81 <h1 class="i18n_options_blocking_title"></h1>
82 <div class="hbox"> 82 <div class="hbox">
83 <div id="blocking-languages"> 83 <div id="blocking-languages">
84 <div class="option-name"> 84 <div class="option-name">
85 <span class="i18n_options_language_title"></span> 85 <span class="i18n_options_language_title"></span>
86 <div class="tooltip"> 86 <span class="i18n_options_readMore read-more"
87 <span class="i18n_options_readMore"></span> 87 data-tooltip="options_language_title_tooltip"
88 <div role="tooltip"> 88 data-tooltip-image="skin/tooltips/block.png"></span>
89 <img src="skin/tooltips/block.png" alt="" />
90 <p class="i18n_options_language_title_tooltip"></p>
91 <div class="notes">
92 <p class="i18n_options_language_title_tooltip_notes_1">< /p>
93 <p class="i18n_options_language_title_tooltip_notes_2">< /p>
94 </div>
95 </div>
96 </div>
97 </div> 89 </div>
98 <ul id="blocking-languages-table" class="table list"> 90 <ul id="blocking-languages-table" class="table list">
99 <template> 91 <template>
100 <button role="checkbox" class="control"></button> 92 <button role="checkbox" class="control"></button>
101 <span class="display"></span> 93 <span class="display"></span>
102 </template> 94 </template>
103 </ul> 95 </ul>
104 <div class="controls"> 96 <div class="controls">
105 <button data-action="open-dialog" data-dialog="language"> 97 <button data-action="open-dialog" data-dialog="language">
106 <span class="icon icon-add"></span> 98 <span class="icon icon-add"></span>
107 <span class="i18n_options_language_add"></span> 99 <span class="i18n_options_language_add"></span>
108 </button> 100 </button>
109 </div> 101 </div>
110 </div> 102 </div>
111 <div id="further-blocking"> 103 <div id="further-blocking">
112 <div class="option-name"> 104 <div class="option-name">
113 <strong class="i18n_options_furtherBlocking_title"></strong> 105 <strong class="i18n_options_more_title"></strong>
114 <div class="tooltip"> 106 <span class="i18n_options_readMore read-more"
115 <span class="i18n_options_readMore"></span> 107 data-tooltip="options_more_title_tooltip"
116 <div role="tooltip" class="flip-vertical"> 108 data-tooltip-image="skin/tooltips/more.png"
117 <img src="skin/tooltips/more.png" alt="" /> 109 data-tooltip-flip="horizontal"></span>
118 <p class="i18n_options_furtherBlocking_title_tooltip"></p>
119 </div>
120 </div>
121 </div> 110 </div>
122 <div id="custom-wrapper"> 111 <div id="custom-wrapper">
123 <ul id="recommend-list-table" class="table list"> 112 <ul id="recommend-list-table" class="table list">
124 <template> 113 <template>
125 <button role="checkbox" class="control"></button> 114 <button role="checkbox" class="control"></button>
126 <span class="display"></span> 115 <div class="fill">
saroyanm 2016/03/24 18:27:50 Why do we need this fill wrapper ?
Thomas Greiner 2016/05/31 17:00:01 To fill the space between the checkbox and the "po
saroyanm 2016/06/08 15:48:31 Got it, yes make sense to take care of that during
116 <span class="display"
117 data-tooltip="options_more_%value%_tooltip"
118 data-tooltip-value=""
119 data-tooltip-native></span>
120 </div>
127 <span class="i18n_options_popular popular"></span> 121 <span class="i18n_options_popular popular"></span>
128 </template> 122 </template>
129 </ul> 123 </ul>
130 <ul id="custom-list-table" class="table list"> 124 <ul id="custom-list-table" class="table list">
131 <template> 125 <template>
132 <button role="checkbox" class="control"></button> 126 <button role="checkbox" class="control"></button>
133 <span class="display"></span> 127 <span class="display"></span>
134 </template> 128 </template>
135 </ul> 129 </ul>
136 </div> 130 </div>
137 <div class="controls"> 131 <div class="controls">
138 <button data-action="open-dialog" data-dialog="custom"> 132 <button data-action="open-dialog" data-dialog="custom">
139 <span class="icon icon-add"></span> 133 <span class="icon icon-add"></span>
140 <span class="i18n_options_furtherBlocking_add"><span> 134 <span class="i18n_options_more_add"><span>
141 </button> 135 </button>
142 </div> 136 </div>
143 </div> 137 </div>
144 </div> 138 </div>
145 </div> 139 </div>
146 <div> 140 <div>
147 <h1 class="i18n_options_exceptions_title"></h1> 141 <h1 class="i18n_options_exceptions_title"></h1>
148 <div class="hbox"> 142 <div class="hbox">
149 <div id="acceptable-ads"> 143 <div id="acceptable-ads">
150 <div class="option-name"> 144 <div class="option-name">
151 <strong class="i18n_options_acceptableAds_title"></strong> 145 <strong class="i18n_options_acceptableAds_title"></strong>
152 <div class="tooltip"> 146 <span class="i18n_options_readMore read-more"
153 <span class="i18n_options_readMore"></span> 147 data-tooltip="options_acceptableAds_title_tooltip"
154 <div role="tooltip"> 148 data-tooltip-image="skin/tooltips/acceptable-ads.png"></sp an>
155 <img src="skin/tooltips/acceptable-ads.png" alt="" />
156 <p class="i18n_options_acceptableAds_title_tooltip_1"></p>
157 <p class="i18n_options_acceptableAds_title_tooltip_2"></p>
158 <p class="i18n_options_acceptableAds_title_tooltip_3"></p>
159 </div>
160 </div>
161 </div> 149 </div>
162 <ul id="acceptableads-table" class="table list"> 150 <ul id="acceptableads-table" class="table list">
163 <template> 151 <template>
164 <button role="checkbox" class="control"></button> 152 <button role="checkbox" class="control"></button>
165 <span class="display"></span> 153 <span class="display"></span>
166 </template> 154 </template>
167 </ul> 155 </ul>
168 </div> 156 </div>
169 <div id="whitelisting"> 157 <div id="whitelisting">
170 <div class="option-name"> 158 <div class="option-name">
171 <strong class="i18n_options_whitelisted_title"></strong> 159 <strong class="i18n_options_whitelisted_title"></strong>
172 <div class="tooltip"> 160 <span class="i18n_options_readMore read-more"
173 <span class="i18n_options_readMore"></span> 161 data-tooltip="options_whitelisted_title_tooltip"
174 <div role="tooltip" class="flip-vertical"> 162 data-tooltip-image="skin/tooltips/whitelisted.png"
175 <img src="skin/tooltips/whitelisted.png" alt="" /> 163 data-tooltip-flip="horizontal"></span>
176 <p class="i18n_options_whitelisted_title_tooltip_1"></p>
177 <p class="i18n_options_whitelisted_title_tooltip_2"></p>
178 <div class="notes">
179 <p class="i18n_options_whitelisted_title_tooltip_notes"> </p>
180 </div>
181 </div>
182 </div>
183 </div> 164 </div>
184 <ul id="whitelisting-table" class="table list"> 165 <ul id="whitelisting-table" class="table list">
185 <template> 166 <template>
186 <button class="delete control"></button> 167 <button class="delete control"></button>
187 <span class="display"></span> 168 <span class="display"></span>
188 </template> 169 </template>
189 </ul> 170 </ul>
190 <div class="controls"> 171 <div class="controls">
191 <button data-action="edit-domain-exception"> 172 <button data-action="edit-domain-exception">
192 <span class="icon icon-add"></span> 173 <span class="icon icon-add"></span>
(...skipping 15 matching lines...) Expand all
208 </div> 189 </div>
209 </div> 190 </div>
210 </div> 191 </div>
211 </div> 192 </div>
212 193
213 <!-- Advanced tab content --> 194 <!-- Advanced tab content -->
214 <div id="content-advanced" class="tab-content"> 195 <div id="content-advanced" class="tab-content">
215 <div> 196 <div>
216 <h1> 197 <h1>
217 <span class="i18n_options_tweaks_title"></span> 198 <span class="i18n_options_tweaks_title"></span>
218 <a class="i18n_options_readMore tooltip"></a> 199 <a class="i18n_options_readMore read-more tooltip"></a>
219 </h1> 200 </h1>
220 <ul id="tweaks" class="table"> 201 <ul id="tweaks" class="table">
221 <li data-pref="shouldShowBlockElementMenu"> 202 <li data-pref="shouldShowBlockElementMenu">
222 <button role="checkbox" data-action="toggle-pref"></button> 203 <button role="checkbox" data-action="toggle-pref"></button>
223 <span class="i18n_options_tweaks_blockElement"></span> 204 <span class="i18n_options_tweaks_blockElement"></span>
224 </li> 205 </li>
225 <li data-pref="show_devtools_panel"> 206 <li data-pref="show_devtools_panel">
226 <button role="checkbox" data-action="toggle-pref"></button> 207 <button role="checkbox" data-action="toggle-pref"></button>
227 <span class="i18n_options_tweaks_showDevToolsPanel"></span> 208 <span class="i18n_options_tweaks_showDevToolsPanel"></span>
228 </li> 209 </li>
229 <li data-pref="notifications_ignoredcategories"> 210 <li data-pref="notifications_ignoredcategories">
230 <button role="checkbox" data-action="toggle-pref"></button> 211 <button role="checkbox" data-action="toggle-pref"></button>
231 <span class="i18n_options_tweaks_showNotifications"></span> 212 <span class="i18n_options_tweaks_showNotifications"></span>
232 </li> 213 </li>
233 <li data-pref="safari_contentblocker"> 214 <li data-pref="safari_contentblocker">
234 <button role="checkbox" data-action="toggle-pref"></button> 215 <button role="checkbox" data-action="toggle-pref"></button>
235 <span class="i18n_options_tweaks_safariContentBlocker"></span> 216 <span class="i18n_options_tweaks_safariContentBlocker"></span>
236 </li> 217 </li>
237 </ul> 218 </ul>
238 </div> 219 </div>
239 220
240 <div> 221 <div>
241 <h1> 222 <h1>
242 <span class="i18n_options_filterList_title"></span> 223 <span class="i18n_options_filterList_title"></span>
243 <a class="i18n_options_readMore tooltip"></a> 224 <a class="i18n_options_readMore read-more tooltip"></a>
244 </h1> 225 </h1>
245 <ul class="tabs horizontal"> 226 <ul class="tabs horizontal">
246 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li> 227 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li>
247 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li> 228 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li>
248 </ul> 229 </ul>
249 <div id="filter-lists"> 230 <div id="filter-lists">
250 <div id="all-filter-lists"> 231 <div id="all-filter-lists">
251 <div class="table-header"> 232 <div class="table-header">
252 <h3 class="i18n_options_column_name"></h3> 233 <h3 class="i18n_options_column_name"></h3>
253 <h3 class="i18n_options_column_date"></h3> 234 <h3 class="i18n_options_column_date"></h3>
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 <div class="url"></div> 391 <div class="url"></div>
411 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 392 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
412 </div> 393 </div>
413 </div> 394 </div>
414 </div> 395 </div>
415 <!-- Placeholder element to determine when to wrap focus around --> 396 <!-- Placeholder element to determine when to wrap focus around -->
416 <span class="focus-last" tabindex="0"></span> 397 <span class="focus-last" tabindex="0"></span>
417 </div> 398 </div>
418 </body> 399 </body>
419 </html> 400 </html>
OLDNEW
« no previous file with comments | « locale/en-US/options.json ('k') | options.js » ('j') | options.js » ('J')

Powered by Google App Engine
This is Rietveld