Unified Diff: options.html
Issue 29334038:
Issue 2802/2358 - Dynamically generate tooltips in options page (Closed)
Patch Set: Rebased to 536c9b810423
Created March 21, 2016, 2:04 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« locale/en-US/options.json ('k')
|
options.js » ('j')
|
options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.html |
| =================================================================== |
| --- a/options.html |
| +++ b/options.html |
| @@ -83,17 +83,9 @@ |
| <div id="blocking-languages"> |
| <div class="option-name"> |
| <span class="i18n_options_language_title"></span> |
| - <div class="tooltip"> |
| - <span class="i18n_options_readMore"></span> |
| - <div role="tooltip"> |
| - <img src="skin/tooltips/block.png" alt="" /> |
| - <p class="i18n_options_language_title_tooltip"></p> |
| - <div class="notes"> |
| - <p class="i18n_options_language_title_tooltip_notes_1"></p> |
| - <p class="i18n_options_language_title_tooltip_notes_2"></p> |
| - </div> |
| - </div> |
| - </div> |
| + <span class="i18n_options_readMore read-more" |
| + data-tooltip="options_language_title_tooltip" |
| + data-tooltip-image="skin/tooltips/block.png"></span> |
| </div> |
| <ul id="blocking-languages-table" class="table list"> |
| <template> |
| @@ -110,20 +102,22 @@ |
| </div> |
| <div id="further-blocking"> |
| <div class="option-name"> |
| - <strong class="i18n_options_furtherBlocking_title"></strong> |
| - <div class="tooltip"> |
| - <span class="i18n_options_readMore"></span> |
| - <div role="tooltip" class="flip-vertical"> |
| - <img src="skin/tooltips/more.png" alt="" /> |
| - <p class="i18n_options_furtherBlocking_title_tooltip"></p> |
| - </div> |
| - </div> |
| + <strong class="i18n_options_more_title"></strong> |
| + <span class="i18n_options_readMore read-more" |
| + data-tooltip="options_more_title_tooltip" |
| + data-tooltip-image="skin/tooltips/more.png" |
| + data-tooltip-flip="horizontal"></span> |
| </div> |
| <div id="custom-wrapper"> |
| <ul id="recommend-list-table" class="table list"> |
| <template> |
| <button role="checkbox" class="control"></button> |
| - <span class="display"></span> |
| + <div class="fill"> |
|
saroyanm
2016/03/24 18:27:50
Why do we need this fill wrapper ?
Thomas Greiner
2016/05/31 17:00:01
To fill the space between the checkbox and the "po
saroyanm
2016/06/08 15:48:31
Got it, yes make sense to take care of that during
|
| + <span class="display" |
| + data-tooltip="options_more_%value%_tooltip" |
| + data-tooltip-value="" |
| + data-tooltip-native></span> |
| + </div> |
| <span class="i18n_options_popular popular"></span> |
| </template> |
| </ul> |
| @@ -137,7 +131,7 @@ |
| <div class="controls"> |
| <button data-action="open-dialog" data-dialog="custom"> |
| <span class="icon icon-add"></span> |
| - <span class="i18n_options_furtherBlocking_add"><span> |
| + <span class="i18n_options_more_add"><span> |
| </button> |
| </div> |
| </div> |
| @@ -149,15 +143,9 @@ |
| <div id="acceptable-ads"> |
| <div class="option-name"> |
| <strong class="i18n_options_acceptableAds_title"></strong> |
| - <div class="tooltip"> |
| - <span class="i18n_options_readMore"></span> |
| - <div role="tooltip"> |
| - <img src="skin/tooltips/acceptable-ads.png" alt="" /> |
| - <p class="i18n_options_acceptableAds_title_tooltip_1"></p> |
| - <p class="i18n_options_acceptableAds_title_tooltip_2"></p> |
| - <p class="i18n_options_acceptableAds_title_tooltip_3"></p> |
| - </div> |
| - </div> |
| + <span class="i18n_options_readMore read-more" |
| + data-tooltip="options_acceptableAds_title_tooltip" |
| + data-tooltip-image="skin/tooltips/acceptable-ads.png"></span> |
| </div> |
| <ul id="acceptableads-table" class="table list"> |
| <template> |
| @@ -169,17 +157,10 @@ |
| <div id="whitelisting"> |
| <div class="option-name"> |
| <strong class="i18n_options_whitelisted_title"></strong> |
| - <div class="tooltip"> |
| - <span class="i18n_options_readMore"></span> |
| - <div role="tooltip" class="flip-vertical"> |
| - <img src="skin/tooltips/whitelisted.png" alt="" /> |
| - <p class="i18n_options_whitelisted_title_tooltip_1"></p> |
| - <p class="i18n_options_whitelisted_title_tooltip_2"></p> |
| - <div class="notes"> |
| - <p class="i18n_options_whitelisted_title_tooltip_notes"></p> |
| - </div> |
| - </div> |
| - </div> |
| + <span class="i18n_options_readMore read-more" |
| + data-tooltip="options_whitelisted_title_tooltip" |
| + data-tooltip-image="skin/tooltips/whitelisted.png" |
| + data-tooltip-flip="horizontal"></span> |
| </div> |
| <ul id="whitelisting-table" class="table list"> |
| <template> |
| @@ -215,7 +196,7 @@ |
| <div> |
| <h1> |
| <span class="i18n_options_tweaks_title"></span> |
| - <a class="i18n_options_readMore tooltip"></a> |
| + <a class="i18n_options_readMore read-more tooltip"></a> |
| </h1> |
| <ul id="tweaks" class="table"> |
| <li data-pref="shouldShowBlockElementMenu"> |
| @@ -240,7 +221,7 @@ |
| <div> |
| <h1> |
| <span class="i18n_options_filterList_title"></span> |
| - <a class="i18n_options_readMore tooltip"></a> |
| + <a class="i18n_options_readMore read-more tooltip"></a> |
| </h1> |
| <ul class="tabs horizontal"> |
| <li class="i18n_options_tab_overview active" data-action="switch-tab" data-tab="advanced-allFilterLists"></li> |
« no previous file with comments
|
« locale/en-US/options.json ('k')
|
options.js » ('j')
|
options.js » ('J')
