filters/humandates.py - Issue 29334171: Issue 3410 - Added date sort / format for press releases

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: filters/humandates.py

Issue 29334171: Issue 3410 - Added date sort / format for press releases (Closed)

Patch Set: Fixed rename, typos, and function names Created Jan. 25, 2016, 4:18 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1
	saroyanm 2016/02/01 16:24:54 Detail: No new line needed in the beginning of the Detail: No new line needed in the beginning of the files. juliandoucette 2016/02/02 16:44:45 Done. Show quoted text On 2016/02/01 16:24:54, saroyanm wrote: > Detail: No new line needed in the beginning of the files. Done.
	2 from datetime import datetime

	3

	4 def humandates(collection, inputFormat='%Y-%m-%d', outputFormat='%B %d, %Y'):
	saroyanm 2016/02/01 16:24:54 Not really sure if naming this function as human d Not really sure if naming this function as human date really makes sense, because you also pass the output format as parameter, so this can be changed anytime. I think previous name was better "datesort". juliandoucette 2016/02/02 16:44:45 I changed it because it did more than sort. In th Show quoted text On 2016/02/01 16:24:54, saroyanm wrote: > Not really sure if naming this function as human date really makes sense, > because you also pass the output format as parameter, so this can be changed > anytime. I think previous name was better "datesort". I changed it because it did more than sort. In the next patch I will separate the datesart and the humanize_date functionality.
	5 if inputFormat != outputFormat:
	Sebastian Noack 2016/02/01 18:01:22 This check is redundant. No need for premature mic This check is redundant. No need for premature micro-optimizations here. juliandoucette 2016/02/02 16:44:45 Done. Show quoted text On 2016/02/01 18:01:22, Sebastian Noack wrote: > This check is redundant. No need for premature micro-optimizations here. Done.
	6 for item in collection:

	7 item[0] = datetime.strftime(datetime.strptime(item[0], inputFormat), outpu tFormat)
	Sebastian Noack 2016/02/01 18:01:23 A filter changing it's input in-place is quite une A filter changing it's input in-place is quite unexpected ...and a footgun. juliandoucette 2016/02/02 16:44:45 I agree. In the next patch I will manipulate a cop Show quoted text On 2016/02/01 18:01:23, Sebastian Noack wrote: > A filter changing it's input in-place is quite unexpected ...and a footgun. I agree. In the next patch I will manipulate a copy of the input. See humanize_dates.
	8 return sorted(collection, reverse=True, key=lambda date: datetime.strptime(dat e[0], outputFormat))

OLD	NEW

« no previous file with comments | « no previous file | filters/randomsortbydate.py » ('j') | filters/randomsortbydate.py » ('J')