filters/humanize_date.py - Issue 29334171: Issue 3410 - Added date sort / format for press releases

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: filters/humanize_date.py

Issue 29334171: Issue 3410 - Added date sort / format for press releases (Closed)

Left Patch Set: Changed humanize_dates to format a single date and removed space before argument list Created Feb. 4, 2016, 10:03 a.m.

Right Patch Set: Fixed datetime call Created Feb. 9, 2016, 4 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 import datetime, copy	1 from datetime import datetime
Sebastian Noack 2016/02/04 11:05:06 The import for the "copy" module isn't necessary a The import for the "copy" module isn't necessary anymore. juliandoucette 2016/02/04 11:18:39 Done. Good catch. Show quoted text On 2016/02/04 11:05:06, Sebastian Noack wrote: > The import for the "copy" module isn't necessary anymore. Done. Good catch.
2	2

3 def humanize_date(date):	3 def humanize_date(date):

4 return datetime.datetime.strftime(	4 return datetime.strptime(date, "%Y-%m-%d").strftime("%B %d, %Y")
Sebastian Noack 2016/02/04 11:05:06 Simply, call methods on the instance itself, not o Simply, call methods on the instance itself, not on the class passing the instance: datetime.datetime.strptime(date, "%Y-%m-%d").strftime("%B %d, %Y") juliandoucette 2016/02/04 11:18:39 Done. I was copying the style of the previous date Show quoted text On 2016/02/04 11:05:06, Sebastian Noack wrote: > Simply, call methods on the instance itself, not on the class passing the > instance: > > datetime.datetime.strptime(date, "%Y-%m-%d").strftime("%B %d, %Y") Done. I was copying the style of the previous datesort function. I will fix that function too in the next patch.
5 datetime.datetime.strptime(date, "%Y-%m-%d"),

6 "%B %d, %Y")

LEFT	RIGHT