filters/humanize_date.py - Issue 29334171: Issue 3410 - Added date sort / format for press releases

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: filters/humanize_date.py

Issue 29334171: Issue 3410 - Added date sort / format for press releases (Closed)

Left Patch Set: Changed teamsort to be consistent with fixed import Created Feb. 4, 2016, 11:17 a.m.

Right Patch Set: Fixed datetime call Created Feb. 9, 2016, 4 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 from datetime import datetime	1 from datetime import datetime

2	2

3 def humanize_date(date):	3 def humanize_date(date):

4 return datetime.strftime(	4 return datetime.strptime(date, "%Y-%m-%d").strftime("%B %d, %Y")
Sebastian Noack 2016/02/04 11:31:42 That is not what I meant. You still call the strft That is not what I meant. You still call the strftime method on the datetime class passing in the instance. However, you can simply call the method on the instance directly, which is not only shorter, but makes the code also easier to read as you write it in the order the actions are performed. datetime.strptime(date, "%Y-%m-%d").strftime("%B %d, %Y") juliandoucette 2016/02/09 16:01:16 Done. Show quoted text On 2016/02/04 11:31:42, Sebastian Noack wrote: > That is not what I meant. You still call the strftime method on the datetime > class passing in the instance. However, you can simply call the method on the > instance directly, which is not only shorter, but makes the code also easier to > read as you write it in the order the actions are performed. > > datetime.strptime(date, "%Y-%m-%d").strftime("%B %d, %Y") Done.
5 datetime.strptime(date, "%Y-%m-%d"),

6 "%B %d, %Y")

LEFT	RIGHT