Issue 3532 - Generate animation images at runtime

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 109 matching lines @@
   onclick: function(page)
   {
     page.sendMessage({type: "clickhide-new-filter"});
   }
 };
 
 // Adds or removes browser action icon according to options.
 function refreshIconAndContextMenu(page)
 {
   var whitelisted = isPageWhitelisted(page);
-  updateIcon(page, whitelisted);
+  updateIcon(page, whitelisted && true || false);

[Sebastian Noack, 2016/01/21 18:11:01]

Why mind casting to bool here?

[kzar, 2016/01/21 21:07:30]

Because the documentation for updateIcon says it expects a bool, but I realised
we were actually passing either a filter or null. In a previous iteration of my
work it mattered, now it doesn't so much but I still figured I should correct
the mistake.

[Sebastian Noack, 2016/01/22 15:59:15]

Well, documented type annotations or not, JavaScript is still a lazy typed
language. And adding the extra boilerplate to coerce arguments to a particular
type seems a little backwards.

[kzar, 2016/01/22 16:49:34]

Ok, I'll just remove this change.

 
   // show or hide the context menu entry dependent on whether
   // adblocking is active on that page
   page.contextMenus.removeAll();
   if (Prefs.shouldShowBlockElementMenu && !whitelisted && htmlPages.has(page))
     page.contextMenus.create(contextMenuItem);
 }
 
 function refreshIconAndContextMenuForAllPages()
 {
@@ skipping 267 matching lines @@
   }
 });
 
 // update icon when page changes location
 ext.pages.onLoading.addListener(function(page)
 {
   page.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(page);
   showNextNotificationForUrl(page.url);
 });