Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: safari/icons/abp-16.png
Issue
29334223
:
Issue 3532 - Generate animation images at runtime (Closed)
Patch Set: Don't bother generate Safari icons at build time
Created Jan. 21, 2016, 10:45 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Addressed initial feedback
Patch Set 3: Avoid warnings when closing tabs during animation
Patch Set 4: Don't bother generate Safari icons at build time
Patch Set 5: Addressed further feedback
Patch Set 6: Addressed more feedback
Patch Set 7: Rebased
Patch Set 8: Addressed some more feedback
Patch Set 9: Handle tab switching / closing during animations
Patch Set 10: Pre render frames, listen for onactivated
Patch Set 11: Avoid exceptions when active tab is closed
Patch Set 12: Fixed bug in animationStep counter inc
Patch Set 13: Addressed more feedback!
Patch Set 14: We don't need to convert icons to data URLs
Patch Set 15: Iterate over size in inner loop
Patch Set 16: Removed NOOP callback, renamed "greyed" variable
Patch Set 17: Fix onActivated dispatch for Safari
Patch Set 18: Remove stopAnimation closure and hard coded opacity range
Patch Set 19: Addressed final nits
Right:
Patch Set 1: None
Patch Set 2: Addressed initial feedback
Patch Set 3: Avoid warnings when closing tabs during animation
Patch Set 4: Don't bother generate Safari icons at build time
Patch Set 5: Addressed further feedback
Patch Set 6: Addressed more feedback
Patch Set 7: Rebased
Patch Set 8: Addressed some more feedback
Patch Set 9: Handle tab switching / closing during animations
Patch Set 10: Pre render frames, listen for onactivated
Patch Set 11: Avoid exceptions when active tab is closed
Patch Set 12: Fixed bug in animationStep counter inc
Patch Set 13: Addressed more feedback!
Patch Set 14: We don't need to convert icons to data URLs
Patch Set 15: Iterate over size in inner loop
Patch Set 16: Removed NOOP callback, renamed "greyed" variable
Patch Set 17: Fix onActivated dispatch for Safari
Patch Set 18: Remove stopAnimation closure and hard coded opacity range
Patch Set 19: Addressed final nits
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
background.js
lib/icon.js
lib/notificationHelper.js
lib/utils.js
metadata.chrome
metadata.safari
safari/icons/abp-16.png
safari/icons/abp-16-notification-critical.png
safari/icons/abp-16-notification-information.png
safari/icons/abp-32.png
safari/icons/abp-32-notification-critical.png
safari/icons/abp-32-notification-information.png
View unified diff
|
Download patch
« metadata.safari
('K') |
« metadata.safari
('k') |
safari/icons/abp-16-notification-critical.png »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« metadata.safari
('K') |
« metadata.safari
('k') |
safari/icons/abp-16-notification-critical.png »
('j') |
no next file with comments »
Edit Message
Issue 29334223: Issue 3532 - Generate animation images at runtime (Closed)
Created Jan. 21, 2016, 5:35 p.m. by kzar
Modified Jan. 26, 2016, 11:17 p.m.
Reviewers: Sebastian Noack
Base URL:
Comments: 119
+ 8 drafts
This is Rietveld