Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/ext/background.js

Issue 29334223: Issue 3532 - Generate animation images at runtime (Closed)
Left Patch Set: Addressed initial feedback Created Jan. 21, 2016, 8:58 p.m.
Right Patch Set: Addressed final nits Created Jan. 26, 2016, 10:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | lib/icon.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 } 92 }
93 93
94 chrome.tabs.query(rawInfo, function(tabs) 94 chrome.tabs.query(rawInfo, function(tabs)
95 { 95 {
96 callback(tabs.map(function(tab) 96 callback(tabs.map(function(tab)
97 { 97 {
98 return new Page(tab); 98 return new Page(tab);
99 })); 99 }));
100 }); 100 });
101 }, 101 },
102 onLoading: new ext._EventTarget() 102 onLoading: new ext._EventTarget(),
103 onActivated: new ext._EventTarget()
103 }; 104 };
104 105
105 chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab) 106 chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab)
106 { 107 {
107 if (changeInfo.status == "loading") 108 if (changeInfo.status == "loading")
108 ext.pages.onLoading._dispatch(new Page(tab)); 109 ext.pages.onLoading._dispatch(new Page(tab));
109 }); 110 });
110 111
111 chrome.webNavigation.onBeforeNavigate.addListener(function(details) 112 chrome.webNavigation.onBeforeNavigate.addListener(function(details)
112 { 113 {
(...skipping 27 matching lines...) Expand all
140 ext._removeFromAllPageMaps(tabId); 141 ext._removeFromAllPageMaps(tabId);
141 delete framesOfTabs[tabId]; 142 delete framesOfTabs[tabId];
142 } 143 }
143 144
144 chrome.tabs.onReplaced.addListener(function(addedTabId, removedTabId) 145 chrome.tabs.onReplaced.addListener(function(addedTabId, removedTabId)
145 { 146 {
146 forgetTab(removedTabId); 147 forgetTab(removedTabId);
147 }); 148 });
148 149
149 chrome.tabs.onRemoved.addListener(forgetTab); 150 chrome.tabs.onRemoved.addListener(forgetTab);
151
152 chrome.tabs.onActivated.addListener(details =>
153 {
154 ext.pages.onActivated._dispatch(new Page({id: details.tabId}));
155 });
150 156
151 157
152 /* Browser actions */ 158 /* Browser actions */
153 159
154 var BrowserAction = function(tabId) 160 var BrowserAction = function(tabId)
155 { 161 {
156 this._tabId = tabId; 162 this._tabId = tabId;
157 this._changes = null; 163 this._changes = null;
158 }; 164 };
159 BrowserAction.prototype = { 165 BrowserAction.prototype = {
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 callback(new Page(tab)); 574 callback(new Page(tab));
569 } 575 }
570 else 576 else
571 { 577 {
572 ext.pages.open(optionsUrl, callback); 578 ext.pages.open(optionsUrl, callback);
573 } 579 }
574 }); 580 });
575 }); 581 });
576 }; 582 };
577 })(); 583 })();
LEFTRIGHT
« no previous file | lib/icon.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld