metadata.safari - Issue 29334223: Issue 3532 - Generate animation images at runtime

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.safari

Issue 29334223: Issue 3532 - Generate animation images at runtime (Closed)

Left Patch Set: Don't bother generate Safari icons at build time Created Jan. 21, 2016, 10:45 p.m.

Right Patch Set: Addressed final nits Created Jan. 26, 2016, 10:57 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.common	2 inherit = metadata.common

3	3

4 [general]	4 [general]

5 basename = adblockplussafari	5 basename = adblockplussafari

6 author = Eyeo GmbH	6 author = Eyeo GmbH

7 homepage = https://adblockplus.org/	7 homepage = https://adblockplus.org/

8 updateURL = https://update.adblockplus.org/adblockplussafari/updates.plist	8 updateURL = https://update.adblockplus.org/adblockplussafari/updates.plist

9	9

10 [contentScripts]	10 [contentScripts]

11 document_start = ext/common.js ext/content.js cssProperties.js include.preload.j s include.youtube.js	11 document_start = ext/common.js ext/content.js cssProperties.js include.preload.j s include.youtube.js

12	12

13 [mapping]	13 [mapping]

14 ext/content.js = safari/ext/content.js	14 ext/content.js = safari/ext/content.js

15 ext/popup.js = safari/ext/popup.js	15 ext/popup.js = safari/ext/popup.js

16 include.youtube.js = safari/include.youtube.js	16 include.youtube.js = safari/include.youtube.js

17 Icon.png = adblockplusui/skin/abp-128.png	17 Icon.png = adblockplusui/skin/abp-128.png

18 icons/abp-16.png = safari/icons/abp-16.png	18 icons/abp-16.png = safari/icons/abp-16.png

19 icons/abp-16@2x.png = safari/icons/abp-32.png	19 icons/abp-16@2x.png = safari/icons/abp-32.png

20 icons/abp-16-notification-critical.png = safari/icons/abp-16-notification-critic al.png	20 icons/abp-16-notification-critical.png = safari/icons/abp-16-notification-critic al.png

	21 icons/abp-16-notification-critical@2x.png = safari/icons/abp-32-notification-cri tical.png

21 icons/abp-16-notification-information.png = safari/icons/abp-16-notification-inf ormation.png	22 icons/abp-16-notification-information.png = safari/icons/abp-16-notification-inf ormation.png

22 icons/abp-16-notification-critical@2x.png = safari/icons/abp-32-notification-cri tical.png
Sebastian Noack 2016/01/22 15:59:15 Nit: For consistency this should be above the line Nit: For consistency this should be above the line above. kzar 2016/01/22 16:49:35 Done. Show quoted text On 2016/01/22 15:59:15, Sebastian Noack wrote: > Nit: For consistency this should be above the line above. Done.
23 icons/abp-16-notification-information@2x.png = safari/icons/abp-32-notification- information.png	23 icons/abp-16-notification-information@2x.png = safari/icons/abp-32-notification- information.png

24	24

25	25

26 [convert_js]	26 [convert_js]

27 ext/common.js = ext/common.js safari/ext/common.js	27 ext/common.js = ext/common.js safari/ext/common.js

28 ext/background.js = ext/background.js safari/ext/background.js --arg brace_style =expand	28 ext/background.js = ext/background.js safari/ext/background.js --arg brace_style =expand

29 lib/adblockplus.js -= lib/uninstall.js	29 lib/adblockplus.js -= lib/uninstall.js

30	30

31 [popovers]	31 [popovers]

32 popup_filename = popup.html	32 popup_filename = popup.html

33	33

34 [toolbar_items]	34 [toolbar_items]

35 item_image = icons/abp-16.png	35 item_image = icons/abp-16.png

36 item_popover = popup	36 item_popover = popup

LEFT	RIGHT