Issue #2230, #3391 - Load filters on "download begin" event

src/plugin/PluginFilter.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 112 matching lines @@
 {
   // (Tag,Name) -> Filter
   typedef std::multimap<std::pair<std::wstring, std::wstring>, CFilterElementHide> TFilterElementHideTagsNamed;
   // Tag -> Filter
   typedef std::multimap<std::wstring, CFilterElementHide> TFilterElementHideTags;
   TFilterElementHideTagsNamed m_elementHideTagsId;
   TFilterElementHideTagsNamed m_elementHideTagsClass;
   TFilterElementHideTags m_elementHideTags;
   bool AddFilterElementHide(std::wstring filter);
   bool LoadHideFilters();
-  const std::wstring& domain;

[sergei, 2016/01/29 10:03:20]

That's very dangerous, make it non-reference.

[Eric, 2016/02/03 18:03:20]

Done.

+  const std::wstring domain;
   InitializerType Initializer() override
   {
     return [this] { LoadHideFilters(); };
   }
 
 public:
   CPluginFilter(const std::wstring& domain)
     : domain(domain)
   {
     SpawnInitializer();
   }
   bool IsElementHidden(const std::wstring& tag, IHTMLElement* pEl, const std::wstring& domain, const std::wstring& indent) const;
   void EnsureInitialized() { DetachedInitializer::EnsureInitialized(); }
 };
 
 
 #endif // _PLUGIN_FILTER_H_