Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginTabBase.h

Issue 29334397: Issue #2230, #3391 - Load filters on "download begin" event
Patch Set: Created Jan. 22, 2016, 6:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginTabBase.h
===================================================================
--- a/src/plugin/PluginTabBase.h
+++ b/src/plugin/PluginTabBase.h
@@ -39,7 +39,7 @@
std::thread m_thread;
std::atomic<bool> m_continueThreadRunning;
public:
- CPluginFilter m_filter;
+ std::unique_ptr<CPluginFilter> filter;
Eric 2016/02/03 18:03:20 As simple as this change looks, it's the core of t
private:
void ThreadProc();
CComAutoCriticalSection m_criticalSectionCache;
@@ -57,6 +57,7 @@
virtual void OnActivate();
virtual void OnUpdate();
virtual void OnNavigate(const std::wstring& url);
+ void OnDownloadBegin();
virtual void OnDownloadComplete(IWebBrowser2* browser);
virtual void OnDocumentComplete(IWebBrowser2* browser, const std::wstring& url, bool isDocumentBrowser);
static DWORD WINAPI TabThreadProc(LPVOID pParam);

Powered by Google App Engine
This is Rietveld