Issue 3580 - Handle missing chrome.webRequest.ResourceType on old Chrome versions

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 358 matching lines @@
       // (e.g. requests initiated by Flash) with the type `other`.
       // https://code.google.com/p/chromium/issues/detail?id=410382
       var match = navigator.userAgent.match(/\bChrome\/(\d+)/);
       if (match)
       {
         var version = parseInt(match[1], 10);
         if (version >= 38 && version <= 48)
           return [["OTHER", "OBJECT", "OBJECT_SUBREQUEST"]];
       }
 
+      // Chrome <44 doesn't have ResourceType.
+      var ResourceType = chrome.webRequest.ResourceType || {};
+
       // Before Chrome 49, requests of the type `font` and `ping`
       // have been reported with the type `other`.
       // https://code.google.com/p/chromium/issues/detail?id=410382
       var otherTypes = ["OTHER", "MEDIA"];
-      if (!("FONT" in chrome.webRequest.ResourceType))
+      if (!("FONT" in ResourceType))
         otherTypes.push("FONT");
-      if (!("PING" in chrome.webRequest.ResourceType))
+      if (!("PING" in ResourceType))
         otherTypes.push("PING");
 
       return [["OBJECT", "OBJECT_SUBREQUEST"], otherTypes];
     }
   };
 
   chrome.tabs.query({}, function(tabs)
   {
     tabs.forEach(function(tab)
     {
@@ skipping 180 matching lines @@
             callback(new Page(tab));
         }
         else
         {
           ext.pages.open(optionsUrl, callback);
         }
       });
     });
   };
 })();