Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29334658: Issue 3587 - Use hiera_hash() to accumulate $adblockplus::users (Closed)

Created:
Jan. 27, 2016, 2:37 a.m. by mathias
Modified:
Feb. 1, 2016, 11:27 a.m.
Reviewers:
Fred
CC:
Felix Dahlke
Visibility:
Public.

Description

(Allows for multiple occurences of adblockplus::user: within Hiera YAML files.)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 3587 - Address feedback from codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/adblockplus/manifests/init.pp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
mathias
Jan. 27, 2016, 2:37 a.m. (2016-01-27 02:37:39 UTC) #1
Fred
https://codereview.adblockplus.org/29334658/diff/29334659/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29334658/diff/29334659/modules/adblockplus/manifests/init.pp#newcode24 modules/adblockplus/manifests/init.pp:24: $users = hiera_hash('adblockplus::users', []), The default value should be ...
Jan. 27, 2016, 3:50 p.m. (2016-01-27 15:50:32 UTC) #2
mathias
https://codereview.adblockplus.org/29334658/diff/29334659/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29334658/diff/29334659/modules/adblockplus/manifests/init.pp#newcode24 modules/adblockplus/manifests/init.pp:24: $users = hiera_hash('adblockplus::users', []), On 2016/01/27 15:50:32, Fred wrote: ...
Jan. 27, 2016, 3:57 p.m. (2016-01-27 15:57:25 UTC) #3
mathias
Jan. 27, 2016, 3:59 p.m. (2016-01-27 15:59:32 UTC) #4
Fred
Jan. 27, 2016, 4:39 p.m. (2016-01-27 16:39:41 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld