Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(310)

Issue 29334723: Issue 3404 - Add platform name to devenv path (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by kzar
Modified:
3 years, 10 months ago
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 3404 - Add platform name to devenv path

Patch Set 1 #

Total comments: 2

Patch Set 2 : Concatinate the strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build.py View 1 chunk +1 line, -1 line 0 comments Download
M packager.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
3 years, 10 months ago (2016-01-27 13:57:19 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29334723/diff/29334724/packager.py File packager.py (right): https://codereview.adblockplus.org/29334723/diff/29334724/packager.py#newcode23 packager.py:23: return os.path.join(baseDir, 'devenv.%s' % type) Nit: We usually use ...
3 years, 10 months ago (2016-01-27 14:16:50 UTC) #2
kzar
Patch Set 2 : Concatinate the strings https://codereview.adblockplus.org/29334723/diff/29334724/packager.py File packager.py (right): https://codereview.adblockplus.org/29334723/diff/29334724/packager.py#newcode23 packager.py:23: return os.path.join(baseDir, ...
3 years, 10 months ago (2016-01-27 14:20:30 UTC) #3
Sebastian Noack
3 years, 10 months ago (2016-01-27 14:20:56 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5