Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: templates/default.tmpl

Issue 29335113: Issue 2675 - Implemented responsive header for web.eyeo.com (Closed)
Left Patch Set: Minor code style and variable scope cleanup Created Feb. 29, 2016, 5:03 p.m.
Right Patch Set: Fixed code style and consistancy issues Created June 23, 2016, 5:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/js/scripts.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html lang="{{locale}}"> 2 <html lang="{{locale}}">
3 <head> 3 <head>
4 <meta charset="UTF-8" /> 4 <meta charset="UTF-8" />
5 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" /> 5 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" />
6 <meta http-equiv="X-UA-Compatible" content="IE=edge"> 6 <meta http-equiv="X-UA-Compatible" content="IE=edge">
7 7
8 {% if title %} 8 {% if title %}
9 <title>{{title}} | Eyeo GmbH</title> 9 <title>{{title}} | Eyeo GmbH</title>
10 {% else %} 10 {% else %}
11 <title>Eyeo GmbH</title> 11 <title>Eyeo GmbH</title>
12 {% endif %} 12 {% endif %}
13 13
14 <link rel="shortcut icon" href="/images/favicon.png" /> 14 <link rel="shortcut icon" href="/images/favicon.png" />
15 15
16 <link rel="stylesheet" href="/css/styles.css" type="text/css" media="all"> 16 <link rel="stylesheet" href="/css/styles.css" type="text/css" media="all">
17 17
18 <!--[if lt IE 9]> 18 <!--[if lt IE 9]>
19 <script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></scri pt> 19 <script src="/js/html5shiv.min.js"></script>
20 <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script> 20 <script src="/js/respond.min.js"></script>
saroyanm 2016/04/08 16:56:10 I think you would like to get both files from our
juliandoucette 2016/04/25 19:08:56 Good catch.
21 <![endif]--> 21 <![endif]-->
22 22
23 <script src="/js/jquery.js"></script> 23 <script src="/js/jquery.js"></script>
24 <script src="/js/scripts.js"></script> 24 <script src="/js/scripts.js"></script>
25 25
26 <link rel="canonical" href="https://eyeo.com/{{ page[:-5] if page.split('/')[- 1] == 'index' else page }}"> 26 <link rel="canonical" href="https://eyeo.com/{{ page[:-5] if page.split('/')[- 1] == 'index' else page }}">
27 27
28 {% block head %} 28 {% block head %}
29 {{head|safe}} 29 {{head|safe}}
30 {% endblock %} 30 {% endblock %}
31 </head> 31 </head>
32 32
33 <body id="top" class="home page page-template-default apollo_validation_on cover wpb-js-composer js-comp-ver-3.6.14.1 vc_responsive"> 33 <body id="top" class="home page page-template-default apollo_validation_on cover wpb-js-composer js-comp-ver-3.6.14.1 vc_responsive">
34 34
35 <header id="header" class="top"> 35 <header id="header" class="top">
36 <div class="content-block"> 36 <div class="content-block">
37 37
38 <a 38 {{"jobs"|linkify(id="logo",title="Eyeo GmbH",rel="home")}}
saroyanm 2016/04/08 16:56:10 While we do have 80 line limit for coding style we
juliandoucette 2016/04/25 19:08:56 Sorry, I thought it was easier to read this way.
saroyanm 2016/05/06 14:49:28 Currently how it's done it's inconsistent, you hav
juliandoucette 2016/05/11 18:11:06 Agreed. Will do.
39 id="logo" 39 <img src="/images/logo.png" srcset="/images/logo.png 1x, /images/logo-2x .png
40 href="{{source.resolve_link("index", locale)[1]}}" 40 2x" height="51px" alt="Eyeo GmbH" />
41 hreflang="{{source.resolve_link("index", locale)[0]}}"
42 title="Eyeo GmbH" rel="home">
43 <img src="/images/tog_logo.png" height="51px" alt="Eyeo GmbH" />
44 </a> 41 </a>
45 42
46 <a 43 <a class="assistive-text" href="#content">
saroyanm 2016/05/06 14:49:28 I can't understand why we have this element and th
juliandoucette 2016/05/11 18:11:06 Providing a "skip to content" link is a standard a
juliandoucette 2016/05/11 18:41:27 Scratch that. I actually just removed one and fixe
47 class="assistive-text" 44 Skip to main content
48 href="#begin-of-content">
49 Skip to primary content
50 </a>
51 <a
52 class="assistive-text"
53 href="#secondary">
54 Skip to secondary content
55 </a> 45 </a>
56 46
57 <button type="button" id="header-hamberger" aria-expanded="false"> 47 <button id="header-hamburger" aria-expanded="false">
58 <span class="assistive-text">Toggle navigation</span> 48 <span class="assistive-text">Toggle navigation</span>
59 <span class="icon-bar"></span> 49 <span class="icon-bar"></span>
60 <span class="icon-bar"></span> 50 <span class="icon-bar"></span>
61 <span class="icon-bar"></span> 51 <span class="icon-bar"></span>
62 </button> 52 </button>
63 53
64 <a 54 <nav id="menu" role="navigation" aria-labelledby="header-hamburger" aria-e xpanded="false">
65 href="{{source.resolve_link("jobs", locale)[1]}}" 55 <h1 class="assistive-text">Main menu</h1>
66 hreflang="{{source.resolve_link("jobs", locale)[0]}}"
67 class="menu-button">
68 Join us - we are hiring!
69 </a>
70
71 <nav
72 id="menu"
73 role="navigation"
74 aria-labelledby="header-hamberger"
75 aria-expanded="false">
76 <h3 class="assistive-text">Main menu</h3>
77 <ul class="menu-list"> 56 <ul class="menu-list">
78 {%- for link, title in [("index", "About Us"), ("services", "Services" ), ("team", "Team"), ("press", "Press"), ("contact", "Contact Us")] %} 57 {%- for link, title in [("index", "About Us"), ("services", "Services" ), ("team", "Team"), ("press", "Press"), ("contact", "Contact Us")] %}
79 {%- if link == page %} 58 {%- if link == page %}
80 <li 59 <li class="current-menu-item">
81 class="menu-item menu-item-type-post_type menu-item-object-page current-menu-item page_item current_page_item">
82 {{link|linkify}} 60 {{link|linkify}}
83 <span>{{title}}</span> 61 <span>{{title}}</span>
84 </a> 62 </a>
85 </li> 63 </li>
86 {%- else %} 64 {%- else %}
87 <li 65 <li>
88 class="menu-item menu-item-type-post_type menu-item-object-page" >
89 {{link|linkify}} 66 {{link|linkify}}
90 <span>{{title}}</span> 67 <span>{{title}}</span>
91 </a> 68 </a>
92 </li> 69 </li>
93 {%- endif %} 70 {%- endif %}
94 {%- endfor %} 71 {%- endfor %}
95 </ul> 72 </ul>
96 </nav> 73 </nav>
74
75 {{"jobs"|linkify(class="menu-button")}}Join us - we are hiring!</a>
97 76
98 </div> 77 </div>
99 </header> 78 </header>
100 79
101 <div id="content"> 80 <div id="content">
102 {{body|safe}} 81 {{body|safe}}
103 </div> 82 </div>
104 83
105 <footer id="footer"> 84 <footer id="footer">
106 <div class="content-block"> 85 <div class="content-block">
107 <a id="footer-contact" href="{{source.resolve_link("contact", locale)[1]}} " hreflang="{{source.resolve_link("contact", locale)[0]}}"> 86 <a id="footer-contact" href="{{source.resolve_link("contact", locale)[1]}} " hreflang="{{source.resolve_link("contact", locale)[0]}}">
108 Made with ♥ in Cologne 87 Made with ♥ in Cologne
109 </a> 88 </a>
110 89
111 <div class="footer-text"> 90 <div class="footer-text">
112 Adblock Plus™ and Acceptable Ads™ are registered trademarks of Eyeo GmbH . 91 Adblock Plus™ and Acceptable Ads™ are registered trademarks of Eyeo GmbH .
113 </div> 92 </div>
114 93
115 <a href="#top" id="to-top" style="opacity: 0;"></a>
116 </div> 94 </div>
117 </footer> 95 </footer>
118 </body> 96 </body>
119 97
120 </html> 98 </html>
LEFTRIGHT
« static/js/scripts.js ('k') | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld