Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/styles.css

Issue 29335113: Issue 2675 - Implemented responsive header for web.eyeo.com (Closed)
Left Patch Set: Fixed minor css style issues Created June 16, 2016, 6:05 p.m.
Right Patch Set: Fixed code style and consistancy issues Created June 23, 2016, 5:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/acceptable-ads-application.html ('k') | static/images/logo.png » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * Fonts 2 * Fonts
3 */ 3 */
4 @font-face { 4 @font-face {
5 font-family: "Lato"; 5 font-family: "Lato";
6 font-style: normal; 6 font-style: normal;
7 font-weight: 400; 7 font-weight: 400;
8 src: local("Lato Regular"), local("Lato-Regular"), url(/fonts/Lato-Regular.wof f) format('woff'); 8 src: local("Lato Regular"), local("Lato-Regular"), url(/fonts/Lato-Regular.wof f) format('woff');
9 } 9 }
10 @font-face { 10 @font-face {
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 h6 97 h6
98 { 98 {
99 font-size:12px; 99 font-size:12px;
100 } 100 }
101 101
102 #header 102 #header
103 { 103 {
104 position: fixed; 104 position: fixed;
105 background-color: #fff; 105 background-color: #fff;
106 width: 100%; 106 width: 100%;
107 top: 0; 107 top: 0px;
saroyanm 2016/06/22 07:54:19 Detail: CSS number values should specify units whe
juliandoucette 2016/06/23 17:25:41 Done.
108 left: 0; 108 left: 0px;
109 box-shadow: 0 0 12px rgba(0,0,0, 0.09); 109 box-shadow: 0px 0px 12px rgba(0,0,0, 0.09);
110 z-index: 10000; 110 z-index: 10000;
111 text-align: right; 111 text-align: right;
112 } 112 }
113 113
114 #header .content-block 114 #header .content-block
115 { 115 {
116 position: relative; 116 position: relative;
117 padding: 15px 10px; 117 padding: 15px 10px;
118 min-height: 32px; 118 min-height: 32px;
119 } 119 }
120 120
121 #header.top .content-block 121 #header.top .content-block
122 { 122 {
123 padding: 25px 10px; 123 padding: 25px 10px;
124 } 124 }
125 125
126 #logo 126 #logo
127 { 127 {
128 position: absolute; 128 position: absolute;
129 top: 7px; 129 top: 7px;
130 left: 10px; 130 left: 10px;
131 } 131 }
132 132
133 #header.top #logo 133 #header.top #logo
134 { 134 {
135 top: 17.5px; 135 top: 17px;
saroyanm 2016/06/22 07:54:19 17.5px, just curious why are you using 0.5px accur
juliandoucette 2016/06/23 17:25:41 Changed.
136 } 136 }
137 137
138 #header .menu-button 138 #header .menu-button
139 { 139 {
140 margin: 0 0 0 25px; 140 margin: 0px 0px 0px 25px;
saroyanm 2016/06/22 07:54:19 Detail: CSS number values should specify units whe
juliandoucette 2016/06/23 17:25:41 Done.
141 } 141 }
142 142
143 #menu 143 #menu
144 { 144 {
145 display: inline; 145 display: inline;
146 vertical-align: middle; 146 vertical-align: middle;
147 } 147 }
148 148
149 .assistive-text 149 .assistive-text
150 { 150 {
151 position: absolute; 151 position: absolute !important;
152 top: -99999px; 152 height: 1px;
saroyanm 2016/06/22 07:54:18 I'm not really familiar with this implementation,
juliandoucette 2016/06/23 17:25:41 See: https://make.wordpress.org/accessibility/201
153 left: -99999px; 153 width: 1px;
154 overflow: hidden;
154 clip: rect(1px, 1px, 1px, 1px); 155 clip: rect(1px, 1px, 1px, 1px);
155 } 156 }
156 157
157 .menu-list 158 .menu-list
158 { 159 {
159 display: inline; 160 display: inline;
160 margin: 0px; 161 margin: 0px;
161 font-size: 15px; 162 font-size: 15px;
162 list-style: none; 163 list-style: none;
163 } 164 }
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
919 padding-right: .1em; 920 padding-right: .1em;
920 border-right-width: 1px; 921 border-right-width: 1px;
921 border-right-width: 1px; 922 border-right-width: 1px;
922 } 923 }
923 924
924 #panels-openings 925 #panels-openings
925 { 926 {
926 margin-top: -40px; 927 margin-top: -40px;
927 } 928 }
928 } 929 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld