Delta Between Two Patch Sets: templates/default.tmpl
Issue 29335113:
Issue 2675 - Implemented responsive header for web.eyeo.com (Closed)
Left Patch Set: Fixed minor css style issues
Created June 16, 2016, 6:05 p.m.
Right Patch Set: Fixed code style and consistancy issues
Created June 23, 2016, 5:23 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« static/js/scripts.js ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html lang="{{locale}}"> | 2 <html lang="{{locale}}"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="UTF-8" /> | 4 <meta charset="UTF-8" /> |
| 5 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" /> | 5 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" /> |
| 6 <meta http-equiv="X-UA-Compatible" content="IE=edge"> | 6 <meta http-equiv="X-UA-Compatible" content="IE=edge"> |
| 7 | 7 |
| 8 {% if title %} | 8 {% if title %} |
| 9 <title>{{title}} | Eyeo GmbH</title> | 9 <title>{{title}} | Eyeo GmbH</title> |
| 10 {% else %} | 10 {% else %} |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 28 {% block head %} | 28 {% block head %} |
| 29 {{head|safe}} | 29 {{head|safe}} |
| 30 {% endblock %} | 30 {% endblock %} |
| 31 </head> | 31 </head> |
| 32 | 32 |
| 33 <body id="top" class="home page page-template-default apollo_validation_on cover wpb-js-composer js-comp-ver-3.6.14.1 vc_responsive"> | 33 <body id="top" class="home page page-template-default apollo_validation_on cover wpb-js-composer js-comp-ver-3.6.14.1 vc_responsive"> |
| 34 | 34 |
| 35 <header id="header" class="top"> | 35 <header id="header" class="top"> |
| 36 <div class="content-block"> | 36 <div class="content-block"> |
| 37 | 37 |
| 38 <a id="logo" href="{{source.resolve_link("index", locale)[1]}}" hreflang=" {{source.resolve_link("index", locale)[0]}}" title="Eyeo GmbH" rel="home"> | 38 {{"jobs"|linkify(id="logo",title="Eyeo GmbH",rel="home")}} |
|
saroyanm
2016/06/22 07:54:24
While we are fixing the header I think it make sen
juliandoucette
2016/06/23 17:25:43
Done.
| |
| 39 <img src="/images/logo.png" srcset="/images/logo.png 1x, /images/logo-2x .png 2x" height="51px" alt="Eyeo GmbH" /> | 39 <img src="/images/logo.png" srcset="/images/logo.png 1x, /images/logo-2x .png |
| 40 2x" height="51px" alt="Eyeo GmbH" /> | |
| 40 </a> | 41 </a> |
| 41 | 42 |
| 42 <a class="assistive-text" href="#content"> | 43 <a class="assistive-text" href="#content"> |
| 43 Skip to main content | 44 Skip to main content |
| 44 </a> | 45 </a> |
| 45 | 46 |
| 46 <button id="header-hamburger" aria-expanded="false"> | 47 <button id="header-hamburger" aria-expanded="false"> |
| 47 <span class="assistive-text">Toggle navigation</span> | 48 <span class="assistive-text">Toggle navigation</span> |
| 48 <span class="icon-bar"></span> | 49 <span class="icon-bar"></span> |
| 49 <span class="icon-bar"></span> | 50 <span class="icon-bar"></span> |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 64 <li> | 65 <li> |
| 65 {{link|linkify}} | 66 {{link|linkify}} |
| 66 <span>{{title}}</span> | 67 <span>{{title}}</span> |
| 67 </a> | 68 </a> |
| 68 </li> | 69 </li> |
| 69 {%- endif %} | 70 {%- endif %} |
| 70 {%- endfor %} | 71 {%- endfor %} |
| 71 </ul> | 72 </ul> |
| 72 </nav> | 73 </nav> |
| 73 | 74 |
| 74 <a href="{{source.resolve_link("jobs", locale)[1]}}" hreflang="{{source.re solve_link("jobs", locale)[0]}}" class="menu-button"> | 75 {{"jobs"|linkify(class="menu-button")}}Join us - we are hiring!</a> |
|
saroyanm
2016/06/22 07:54:24
Same as the comment above you can use linkify:
{{"
juliandoucette
2016/06/23 17:25:43
Done.
| |
| 75 Join us - we are hiring! | |
| 76 </a> | |
| 77 | 76 |
| 78 </div> | 77 </div> |
| 79 </header> | 78 </header> |
| 80 | 79 |
| 81 <div id="content"> | 80 <div id="content"> |
| 82 {{body|safe}} | 81 {{body|safe}} |
| 83 </div> | 82 </div> |
| 84 | 83 |
| 85 <footer id="footer"> | 84 <footer id="footer"> |
| 86 <div class="content-block"> | 85 <div class="content-block"> |
| 87 <a id="footer-contact" href="{{source.resolve_link("contact", locale)[1]}} " hreflang="{{source.resolve_link("contact", locale)[0]}}"> | 86 <a id="footer-contact" href="{{source.resolve_link("contact", locale)[1]}} " hreflang="{{source.resolve_link("contact", locale)[0]}}"> |
| 88 Made with ♥ in Cologne | 87 Made with ♥ in Cologne |
| 89 </a> | 88 </a> |
| 90 | 89 |
| 91 <div class="footer-text"> | 90 <div class="footer-text"> |
| 92 Adblock Plus™ and Acceptable Ads™ are registered trademarks of Eyeo GmbH . | 91 Adblock Plus™ and Acceptable Ads™ are registered trademarks of Eyeo GmbH . |
| 93 </div> | 92 </div> |
| 94 | 93 |
| 95 </div> | 94 </div> |
| 96 </footer> | 95 </footer> |
| 97 </body> | 96 </body> |
| 98 | 97 |
| 99 </html> | 98 </html> |
| LEFT | RIGHT |
« static/js/scripts.js ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
